Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated root to tip of branch v6-22-00-patches #6217

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Sep 7, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2020

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_2_X/rootnext.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2020

-1

Tested at: d90a717

CMSSW: CMSSW_11_2_ROOT622_X_2020-09-06-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4d8f6e/9168/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_ROOT622_X_2020-09-06-2300/src/RecoJets/JetProducers/plugins/ECFAdder.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_ROOT622_X_2020-09-06-2300/src/RecoJets/JetProducers/plugins/FastjetJetProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_ROOT622_X_2020-09-06-2300/src/RecoJets/JetProducers/plugins/FixedGridRhoProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_ROOT622_X_2020-09-06-2300/src/RecoJets/JetProducers/plugins/FixedGridRhoProducerFastjet.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_ROOT622_X_2020-09-06-2300/src/RecoJets/JetProducers/plugins/CSJetProducer.cc: In member function 'virtual void cms::CSJetProducer::runAlgorithm(edm::Event&, const edm::EventSetup&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_ROOT622_X_2020-09-06-2300/src/RecoJets/JetProducers/plugins/CSJetProducer.cc:149:44: error: no matching function for call to 'fastjet::contrib::ConstituentSubtractor::set_do_mass_subtraction(bool)'
     subtractor.set_do_mass_subtraction(true);
                                            ^
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_ROOT622_X_2020-09-06-2300/src/RecoJets/JetProducers/plugins/CSJetProducer.cc:11:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/fastjet-contrib/1.044/include/fastjet/contrib/ConstituentSubtractor.hh:185:10: note: candidate: 'void fastjet::contrib::ConstituentSubtractor::set_do_mass_subtraction()'
     void set_do_mass_subtraction();


@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2020

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@smuzaffar
Copy link
Contributor

please test
testing based on latest IB

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2020

+1
Tested at: d90a717
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4d8f6e/9193/summary.html
CMSSW: CMSSW_11_2_ROOT622_X_2020-09-07-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4d8f6e/9193/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609667
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2609633
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@smuzaffar
Copy link
Contributor

+externals
comparison failures are due to log messages

@smuzaffar smuzaffar merged commit 2494350 into cms-sw:IB/CMSSW_11_2_X/rootnext Sep 9, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2020

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/rootnext IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants