Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump py2/py3 versions of tools with updates in pypi #6295

Merged
merged 5 commits into from Oct 22, 2020

Conversation

davidlange6
Copy link
Contributor

Hopefully I got the various .file additions correct.

Otherwise, onnxruntime has dropped slc6 support in versions newer than 1.3.0. Either our spec files or our pip do not deal nicely with manylinux2014 wheels. [it seems our pip needs to be 19.3, so likely "just" pip that needs to be updated]
@smuzaffar

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2020

A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_11_2_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

@davidlange6 , we should remove the onnxruntime from the pip/requirement.txt file. We build python onxxruntime module via the onnxruntime.spec .

remove onnxruntime
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2020

Pull request #6295 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2020

-1

Tested at: f6e7fe5

  • Build:

I found compilation error when building:

build-external+tensorflow-python3-sources+2.1.0-5394fa
* The action "build-external+tensorflow-python3-sources+2.1.0-5394fa" was not completed successfully because Failed to build tensorflow-python3-sources. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/external/tensorflow-python3-sources/2.1.0-5394fa/log. Final lines of the log file:
const std::array& types) {
^
tensorflow/python/lib/core/bfloat16.cc:608:60: note:   no known conversion for argument 2 from '' to 'PyUFuncGenericFunction' {aka 'void (*)(char**, const long int*, const long int*, void*)'}
tensorflow/python/lib/core/bfloat16.cc:653:36: error: no match for call to '(tensorflow::{anonymous}::Initialize()::&)>) (const char [14], , const std::array&)'
compare_types)) {
^
tensorflow/python/lib/core/bfloat16.cc:608:60: note: candidate: 'tensorflow::{anonymous}::Initialize()::&)>'
const std::array& types) {
^


You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5394fa/9827/summary.html

@davidlange6
Copy link
Contributor Author

ah - right, I think I rediscover that the tensor flow we have is not ready for the newest numpy.

@cmsbuild
Copy link
Contributor

Pull request #6295 was updated.

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 12, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1

Tested at: 58aafa4

CMSSW: CMSSW_11_2_X_2020-10-11-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5394fa/9887/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test run-ipython3 had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Pull request #6295 was updated.

@cmsbuild
Copy link
Contributor

-1

Tested at: 1ae5f3a

CMSSW: CMSSW_11_2_X_2020-10-19-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5394fa/10077/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test GeometryTrackerGeometryBuilderTestDriver had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5394fa/10077/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2543752
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2543723
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@mrodozov
Copy link
Contributor

please test
lets recheck with the unit test not failing

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 21, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 1ae5f3a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5394fa/10173/summary.html
CMSSW: CMSSW_11_2_X_2020-10-20-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5394fa/10173/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2544100
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2544065
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit ebab654 into cms-sw:IB/CMSSW_11_2_X/master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants