New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump py2/py3 versions of tools with updates in pypi #6295
bump py2/py3 versions of tools with updates in pypi #6295
Conversation
please test |
The tests are being triggered in jenkins.
|
A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_11_2_X/master. @cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks. |
@davidlange6 , we should remove the onnxruntime from the pip/requirement.txt file. We build python onxxruntime module via the onnxruntime.spec . |
remove onnxruntime
Pull request #6295 was updated. |
-1 Tested at: f6e7fe5
I found compilation error when building: build-external+tensorflow-python3-sources+2.1.0-5394fa * The action "build-external+tensorflow-python3-sources+2.1.0-5394fa" was not completed successfully because Failed to build tensorflow-python3-sources. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/external/tensorflow-python3-sources/2.1.0-5394fa/log. Final lines of the log file: const std::array& types) { ^ tensorflow/python/lib/core/bfloat16.cc:608:60: note: no known conversion for argument 2 from '' to 'PyUFuncGenericFunction' {aka 'void (*)(char**, const long int*, const long int*, void*)'} tensorflow/python/lib/core/bfloat16.cc:653:36: error: no match for call to '(tensorflow::{anonymous}::Initialize()::&)>) (const char [14], , const std::array&)' compare_types)) { ^ tensorflow/python/lib/core/bfloat16.cc:608:60: note: candidate: 'tensorflow::{anonymous}::Initialize()::&)>' const std::array& types) { ^ You can see the results of the tests here: |
ah - right, I think I rediscover that the tensor flow we have is not ready for the newest numpy. |
Pull request #6295 was updated. |
please test |
The tests are being triggered in jenkins.
|
-1 Tested at: 58aafa4 CMSSW: CMSSW_11_2_X_2020-10-11-2300 I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test run-ipython3 had ERRORS |
Comparison job queued. |
Pull request #6295 was updated. |
-1 Tested at: 1ae5f3a CMSSW: CMSSW_11_2_X_2020-10-19-1100 I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test GeometryTrackerGeometryBuilderTestDriver had ERRORS |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
Hopefully I got the various .file additions correct.
Otherwise, onnxruntime has dropped slc6 support in versions newer than 1.3.0. Either our spec files or our pip do not deal nicely with manylinux2014 wheels. [it seems our pip needs to be 19.3, so likely "just" pip that needs to be updated]
@smuzaffar