Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update root to 6.22 for CMSSW_11_2_X #6300

Merged
merged 1 commit into from Oct 12, 2020
Merged

Update root to 6.22 for CMSSW_11_2_X #6300

merged 1 commit into from Oct 12, 2020

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Oct 11, 2020 •
edited

Backport changes from IB/CMSSW_11_2_X/rootnext branch to get root version 6.22 in CMSSW_11_2_X IBs. Changes include

  • Updating root version which is now build for both python2 and 3
  • Build python packages for both py2/3 which were dependening on root python.
  • Patches yoda to build against new ROOT Python module

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 11, 2020 •
edited

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_2_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar smuzaffar mentioned this pull request Oct 11, 2020
Closed
@cms-sw cms-sw deleted a comment from cmsbuild Oct 11, 2020
@cmsbuild
Copy link
Contributor

+1
Tested at: 3f5b5f2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57feaf/9867/summary.html
CMSSW: CMSSW_11_2_X_2020-10-11-0000
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57feaf/9867/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2542225
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2542202
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@cmsbuild
Copy link
Contributor

-1

Tested at: 3f5b5f2

CMSSW: CMSSW_11_2_X_2020-10-11-0000
SCRAM_ARCH: slc7_aarch64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57feaf/9868/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals

  • Unit Tests:

I found errors in the following unit tests:

---> test BUFU_TEST had ERRORS
---> test testCommonToolsUtil had ERRORS
---> test TestFWCoreServicesDriver had ERRORS
---> test PhiTest had ERRORS
---> test TestConfigDP had ERRORS

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
1325.7 step2

runTheMatrix-results/1325.7_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2/step2_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2.log

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

-1

Tested at: 3f5b5f2

CMSSW: CMSSW_11_2_CLANG_X_2020-10-11-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57feaf/9875/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test BUFU_TEST had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

+1
Tested at: 3f5b5f2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57feaf/9874/summary.html
CMSSW: CMSSW_11_2_X_2020-10-11-2300
SCRAM_ARCH: slc7_amd64_gcc900
Additional comment: 'Compilation

@cmsbuild
Copy link
Contributor

Comparison job queued.

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit 54c442e into IB/CMSSW_11_2_X/master Oct 12, 2020
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57feaf/9875/summary.html

Comparison Summary:

  • You potentially added 4840 lines to the logs
  • Reco comparison results: 13831 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2542225
  • DQMHistoTests: Total failures: 102206
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 2439994
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.008 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 136.793 ): 0.008 KiB JetMET/SUSYDQM
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@smuzaffar smuzaffar deleted the root-6.22 branch October 12, 2020 13:30
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57feaf/9874/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 13082 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2542225
  • DQMHistoTests: Total failures: 83466
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2458737
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available externals-approved fully-signed orp-pending tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smuzaffar @cmsbuild