Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rivet][OpenMP] Disable OpenMP for aarch64 #6432

Merged
merged 1 commit into from Nov 18, 2020

Conversation

smuzaffar
Copy link
Contributor

We noticed many Relvals fails for aarch64 due to OpenMP cannot allocate memory in static TLS block. This is happening as Rivet library is dynamically linked to gomp which CMSSW plugin manager loads using dlopen. We only see such crashes for aarch64 releases, so this PR suggests to disable openmp for aarch64.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_2_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test workflow 1331.0 for slc7_aarch64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 18, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

-1

Tested at: 624548f

CMSSW: CMSSW_11_2_X_2020-11-18-1100
SCRAM_ARCH: slc7_aarch64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c5e72/10843/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - time: date Wed Nov 18 21:31:04 2020-date Wed Nov 18 21:28:06 2020 s - exit: 35584

@cmsbuild
Copy link
Contributor

Comparison job queued.

@smuzaffar
Copy link
Contributor Author

looks good for aarch. There nothing changed for other archs.

@smuzaffar smuzaffar merged commit 4fc2ddc into IB/CMSSW_11_2_X/master Nov 18, 2020
@smuzaffar smuzaffar deleted the rivet-disable-openmp-aarch64 branch November 21, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants