New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BuiidRule: Allow to set flags for header checks via BuildFile #6460
Conversation
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_3_X/master. @cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks. |
PR are tests are not going to run the new change. I am merging it and building an IB with it |
The tests are being triggered in jenkins.
|
-1 Tested at: 1fdc98a CMSSW: CMSSW_11_3_X_2020-11-26-2300 I found follow errors while testing this PR Failed tests: ClangBuild
I found compilation error while trying to compile with clang. Command used:
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2020-11-26-2300/src/PhysicsTools/PatAlgos/plugins/RecoMETExtractor.cc >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2020-11-26-2300/src/PhysicsTools/PatAlgos/plugins/StringResolutionProviderESProducer.cc >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2020-11-26-2300/src/PhysicsTools/PatAlgos/plugins/TauJetCorrFactorsProducer.cc >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2020-11-26-2300/src/PhysicsTools/PatAlgos/plugins/TrackAndVertexUnpacker.cc >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2020-11-26-2300/src/PhysicsTools/PatAlgos/plugins/VertexAssociationProducer.cc /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2020-11-26-2300/src/PhysicsTools/PatAlgos/plugins/PATTriggerProducer.cc:45:21: error: call to implicitly-deleted default constructor of 'pat::PATTriggerProducer::ModuleLabelToPathAndFlags' PATTriggerProducer::PATTriggerProducer(const ParameterSet& iConfig) ^ /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2020-11-26-2300/src/PhysicsTools/PatAlgos/plugins/PATTriggerProducer.h:145:39: note: default constructor of 'ModuleLabelToPathAndFlags' is implicitly deleted because field 'empty_' of const-qualified type 'const std::vector' would not be initialized const std::vector empty_; ^ |
Comparison not run due to Build errors/Fireworks only changes/No short matrix requested (RelVals and Igprof tests were also skipped) |
No description provided.