Upgrade Herwig to v7.2.1, and add patch to fix crash when reading lhe…

[Dominic-Stafford]

… files with comments

Backport of #6462 for use in 2018 production

[cmsbuild]

A new Pull Request was created by @Dominic-Stafford for branch IB/CMSSW_10_2_X/gcc700.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_10_2_X_2020-11-30-1100/slc6_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11220/console Started: 2020/12/01 15:21

[cmsbuild]

-1

Tested at: 878edd6

CMSSW: CMSSW_10_2_X_2020-11-30-1100
SCRAM_ARCH: slc6_amd64_gcc700
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-049a4e/11220/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following workflows:
1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[mrodozov]

looks like EOS issue, CRAB people are reporting xrootd missing files, too

[Dominic-Stafford]

From looking quickly at the results of these tests, they don't seem to be problems related to Herwig, so would it be possible to just rerun these test once the eos issues are resolved, please?

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_10_2_X_2020-11-30-1100/slc6_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11227/console Started: 2020/12/01 18:19

[cmsbuild]

+1
Tested at: 878edd6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-049a4e/11227/summary.html
CMSSW: CMSSW_10_2_X_2020-11-30-1100
SCRAM_ARCH: slc6_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-049a4e/11227/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 3007546
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3007354
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 28 edm output root files, 31 DQM output files

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_10_2_X_2020-11-30-1100/slc6_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11263/console Started: 2020/12/02 13:36

[cmsbuild]

+1
Tested at: 878edd6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-049a4e/11263/summary.html
CMSSW: CMSSW_10_2_X_2020-11-30-1100
SCRAM_ARCH: slc6_amd64_gcc700

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-049a4e/11263/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 3007546
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3007352
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 28 edm output root files, 31 DQM output files

[mrodozov]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_2_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)