Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to evtgen 2.0.0 and requirements to hepmc 2.06.10, photospp 3… #6494

Merged

Conversation

alberto-sanchez
Copy link
Member

This mean to update EvtGen to 2.0.0 and dependencies:

hepmc 2.06.10,
photospp 3.64,
and tauolpp 1.1.8

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alberto-sanchez (Alberto Sanchez Hernandez) for branch IB/CMSSW_11_3_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@alberto-sanchez
Copy link
Member Author

Not quite ready yet. we need to update update

cms-externals/evtgen#1

first

@cmsbuild
Copy link
Contributor

Pull request #6494 was updated.

@cmsbuild
Copy link
Contributor

Pull request #6494 was updated.

@alberto-sanchez
Copy link
Member Author

please test

@alberto-sanchez
Copy link
Member Author

ignore build-warnings

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-093149/11613/summary.html
CMSSW: CMSSW_11_3_X_2020-12-14-1100/slc7_amd64_gcc900

Build

I found compilation error when building:

>> Checking EDM Class Version for src/SimMuon/Neutron/src/classes_def.xml in libSimMuonNeutron.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libRecoMuonMuonIdentification.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libSimDataFormatsCrossingFrame.so
error: class 'HepMC::HeavyIon' has a different checksum for ClassVersion 10. Increment ClassVersion to 11 and assign it to checksum 1386021189
Suggestion: You can run 'scram build updateclassversion' to generate src/SimDataFormats/GeneratorProducts/src/classes_def.xml.generated with updated ClassVersion
gmake: *** [tmp/slc7_amd64_gcc900/edm_checks/libSimDataFormatsGeneratorProducts.so] Error 1
>> Checking EDM Class Version for src/SimTracker/TrackHistory/src/classes_def.xml in libSimTrackerTrackHistory.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libSimDataFormatsJetMatching.so


@alberto-sanchez
Copy link
Member Author

@smuzaffar , @mrodozov , anything I can do from my side to fix this warnings which apparently does not belong to this PR

@alberto-sanchez
Copy link
Member Author

+1

@qliphy
Copy link
Contributor

qliphy commented Jan 3, 2021

please test

@alberto-sanchez
Copy link
Member Author

please test with cms-sw/cmssw#32452

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2021

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-093149/11915/summary.html
CMSSW: CMSSW_11_3_X_2021-01-02-1100/slc7_amd64_gcc900

Build

I found compilation error when building:

@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libRecoPixelVertexingPixelTriplets.so
>> Checking EDM Class Transients in libSimDataFormatsCrossingFrame.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libRecoMuonMuonIdentification.so
error: class 'HepMC::HeavyIon' has a different checksum for ClassVersion 10. Increment ClassVersion to 11 and assign it to checksum 1386021189
@@@@ ----> OK  EDM Class Transients 
Suggestion: You can run 'scram build updateclassversion' to generate src/SimDataFormats/GeneratorProducts/src/classes_def.xml.generated with updated ClassVersion
>> Checking EDM Class Version for src/SimMuon/DTDigitizer/test/stubs/classes_def.xml in libtestSimMuonDTDigitizer.so
gmake: *** [tmp/slc7_amd64_gcc900/edm_checks/libSimDataFormatsGeneratorProducts.so] Error 1
>> Checking EDM Class Version for src/SimMuon/Neutron/src/classes_def.xml in libSimMuonNeutron.so


@mrodozov
Copy link
Contributor

mrodozov commented Jan 4, 2021

@alberto-sanchez this needs update on the CMSSW side.
see this for example:
cms-sw/cmssw#32420
if you see the the error scram tells you to checkout the package containing HepMC::HeavyIon
and change it's class version to new version

@mrodozov
Copy link
Contributor

mrodozov commented Jan 4, 2021

ah you already did. let me see

@mrodozov
Copy link
Contributor

mrodozov commented Jan 4, 2021

test parameters:

@mrodozov
Copy link
Contributor

mrodozov commented Jan 4, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-093149/11922/summary.html
CMSSW: CMSSW_11_3_X_2021-01-03-2300/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2716967
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2716938
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@mrodozov
Copy link
Contributor

mrodozov commented Jan 5, 2021

+externals
@qliphy lets merge this and cms-sw/cmssw#32420 together on your request
@alberto-sanchez would this work without 32420 ? If yes, I can merge it first otherwise they go together

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2021

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_3_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@alberto-sanchez
Copy link
Member Author

@mrodozov, yes that should work without 32420. In 32452 I am updating the version for HepMC::HeavyIon, which
is the only required for this PR.

@mrodozov
Copy link
Contributor

mrodozov commented Jan 5, 2021

I am updating the version for HepMC::HeavyIon

that will fail if I merge this. @qliphy merge them both when ready

@qliphy
Copy link
Contributor

qliphy commented Jan 7, 2021

In 32452 I am updating the version for HepMC::HeavyIon, which
is the only required for this PR.

@alberto-sanchez This has been done with your commit: cms-sw/cmssw@965f6c6
Right? If so I think we can merge both PRs.

@alberto-sanchez
Copy link
Member Author

That is correct.

@qliphy
Copy link
Contributor

qliphy commented Jan 7, 2021

+1

@cmsbuild cmsbuild merged commit 4218ac4 into cms-sw:IB/CMSSW_11_3_X/master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants