add cuda to ROOT_INCLUDE_PATH

[davidlange6]

(@smuzaffar - are you aware of some reason why ROOT_INCLUDE_PATH should differ from the list of all include paths of cmssw and its externals?)

[davidlange6]

please test

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_11_3_X/master.

@smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

[smuzaffar]

@davidlange6 , in start we blindly start adding include directories to $ROOT_INCLUDE_PATH . this side effect of this is that root cling has to go through all these to find header files at runtime.
Ideally we should only have those include path in $ROOT_INCLUDE_PATH which are part of our dictionaries.

[davidlange6]

Ok- thanks for the clarification - maybe we have a good way to trimming that list with modules.

…

On Mar 18, 2021, at 1:45 PM, Malik Shahzad Muzaffar ***@***.***> wrote: @davidlange6 , in start we blindly start adding include directories to $ROOT_INCLUDE_PATH . this side effect of this is that root cling has to go through all these to find header files at runtime. Ideally we should only have those include path in $ROOT_INCLUDE_PATH which are part of our dictionaries. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-509f96/13592/summary.html
COMMIT: 803fee8
CMSSW: CMSSW_11_3_X_2021-03-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6739/13592/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2639935
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2639906
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_3_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)