Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coral] Bug fix for the DB connection lifetime #6774

Merged
merged 2 commits into from Mar 31, 2021
Merged

[Coral] Bug fix for the DB connection lifetime #6774

merged 2 commits into from Mar 31, 2021

Conversation

qliphy
Copy link
Contributor

@qliphy qliphy commented Mar 31, 2021

backport of #6771
meant for next MWGR

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @qliphy (Qiang Li) for branch IB/CMSSW_11_2_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@qliphy
Copy link
Contributor Author

qliphy commented Mar 31, 2021

please test

coral.spec Outdated

%define source1 git://github.com/%{github_user}/%{n}.git?protocol=https&obj=%{branch}/%{tag}&module=%{cvssrc}&export=%{srctree}&output=/src.tar.gz
## IMPORT scram-project-build
## SUBPACKAGE debug IF %subpackageDebug
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong, we should not delete all of the above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed now.

@cmsbuild
Copy link
Contributor

Pull request #6774 was updated.

@qliphy
Copy link
Contributor Author

qliphy commented Mar 31, 2021

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13c4cc/13876/summary.html
COMMIT: a29d0b6
CMSSW: CMSSW_11_2_X_2021-03-30-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6774/13876/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2527501
  • DQMHistoTests: Total failures: 15
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2527464
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 151 log files, 37 edm output root files, 36 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals
looks good, input relval tests failed due to das/dbs glitches

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

@qliphy , feel free to merge it

@qliphy
Copy link
Contributor Author

qliphy commented Mar 31, 2021

+1

@qliphy
Copy link
Contributor Author

qliphy commented Mar 31, 2021

merge

@cmsbuild cmsbuild merged commit 5bd2a0a into cms-sw:IB/CMSSW_11_2_X/master Mar 31, 2021
@davidlange6
Copy link
Contributor

davidlange6 commented Mar 31, 2021 via email

@smuzaffar
Copy link
Contributor

@davidlange6 , do you mean PR tests or proper validation? The PR tests ran fine

2021/03/31 12:30:27 ERROR failed to parse X509 proxy: crypto/tls: failed to parse key: asn1: syntax error: sequence truncated
2021/03/31 12:30:27 ERROR failed to parse X509 proxy: crypto/tls: failed to parse key: asn1: syntax error: sequence truncated

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 31, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants