New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Coral] Bug fix for the DB connection lifetime #6774
Conversation
A new Pull Request was created by @qliphy (Qiang Li) for branch IB/CMSSW_11_2_X/master. @cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks. |
please test |
coral.spec
Outdated
|
||
%define source1 git://github.com/%{github_user}/%{n}.git?protocol=https&obj=%{branch}/%{tag}&module=%{cvssrc}&export=%{srctree}&output=/src.tar.gz | ||
## IMPORT scram-project-build | ||
## SUBPACKAGE debug IF %subpackageDebug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is wrong, we should not delete all of the above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Fixed now.
Pull request #6774 was updated. |
please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTComparison SummarySummary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@qliphy , feel free to merge it |
+1 |
merge |
@davidlange6 , do you mean PR tests or proper validation? The PR tests ran fine
|
Proper validation (usually required for coral changes) - but perhaps its not required in this case.
… On Mar 31, 2021, at 5:06 PM, Malik Shahzad Muzaffar ***@***.***> wrote:
@davidlange6 , do you mean PR tests or proper validation? The PR tests ran fine
• https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13c4cc/13876/runTheMatrixINPUT-results/runall-report-step123-.log
• 595 595 592 553 102 41 3 1 1 tests passed, 0 0 0 0 0 0 0 0 0 failed
• few Input relvals (where we try to run all workflows with inputs) failed due to dasgoclient glicthes like
2021/03/31 12:30:27 ERROR failed to parse X509 proxy: crypto/tls: failed to parse key: asn1: syntax error: sequence truncated
2021/03/31 12:30:27 ERROR failed to parse X509 proxy: crypto/tls: failed to parse key: asn1: syntax error: sequence truncated
• https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13c4cc/13876/runTheMatrix-results/runall-report-step123-.log
• 36 35 34 25 16 4 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 failed
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
backport of #6771
meant for next MWGR