Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove more python2 tools #6987

Merged
merged 6 commits into from Jun 5, 2021

Conversation

davidlange6
Copy link
Contributor

based on #6869, this change might cause problems (for reasons I didn't understand yet)..

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2021

A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@davidlange6
Copy link
Contributor Author

please abort

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2021

Pull request #6987 was updated.

@davidlange6
Copy link
Contributor Author

please test

@davidlange6
Copy link
Contributor Author

please abort

@davidlange6
Copy link
Contributor Author

please test

I think I have a consistent set finally.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2021

Pull request #6987 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2021

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5978e6/15671/summary.html
COMMIT: 6b12926
CMSSW: CMSSW_12_0_X_2021-06-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6987/15671/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2021

Pull request #6987 was updated.

@davidlange6
Copy link
Contributor Author

davidlange6 commented Jun 5, 2021 via email

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2021

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5978e6/15675/summary.html
COMMIT: ce789c2
CMSSW: CMSSW_12_0_X_2021-06-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6987/15675/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2021

Pull request #6987 was updated.

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5978e6/15676/summary.html
COMMIT: d27ae9f
CMSSW: CMSSW_12_0_X_2021-06-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6987/15676/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2650486
  • DQMHistoTests: Total failures: 18
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2650445
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@davidlange6
Copy link
Contributor Author

hi @smuzaffar - I have another round ready if you think this is ready to be merged.

@smuzaffar
Copy link
Contributor

+externals
comparison diff are due to message logger

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2021

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants