py2-Jinja2 is needed by DXR

[smuzaffar]

FYI @davidlange6

[smuzaffar]

please test

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_0_X/master.

@smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

[davidlange6]

Dxr needs a unit test - can we make one… (and to use python3..) You will also need to add back MarkupSafe for python2...

…

On Jun 5, 2021, at 10:49 AM, Malik Shahzad Muzaffar ***@***.***> wrote: FYI @davidlange6 You can view, comment on, or merge this pull request online at: #6988 Commit Summary • py2-Jinja2 is needed by DXR File Changes • A pip/py2-Jinja2.file (1) • R pip/py3-Jinja2.file (0) • M pip/requirements.txt (2) • M py2-dxr.spec (1) Patch Links: • https://github.com/cms-sw/cmsdist/pull/6988.patch • https://github.com/cms-sw/cmsdist/pull/6988.diff — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[smuzaffar]

@davidlange6 , I will check if I can add a simple unit test for dxr.
No need to explicity add py2-MarkupSafe, the py2-dxr ( https://github.com/cms-sw/cmsdist/pull/6988/files#diff-a8cf4578268220533c594eca1b9ed79e4d1a61fd390f1fdd53c39a5b74417ce8R5) should bring it in indirectly.

[smuzaffar]

please test with cms-sw/cmssw#33984

[davidlange6]

Great - thanks for the unit test!

…

On Jun 5, 2021, at 11:29 AM, Malik Shahzad Muzaffar ***@***.***> wrote: @davidlange6 , I will check if I can add a simple unit test for dxr. No need to explicity add py2-MarkupSafe, the py2-dxr ( https://github.com/cms-sw/cmsdist/pull/6988/files#diff-a8cf4578268220533c594eca1b9ed79e4d1a61fd390f1fdd53c39a5b74417ce8R5) should bring it in indirectly. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c602f4/15673/summary.html
COMMIT: 9cf9dcb
CMSSW: CMSSW_12_0_X_2021-06-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6988/15673/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2650486
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2650451
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)