Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tag for GeneratorInterface-EvtGenInterface to V02-00-11-01-00 #7050

Merged
merged 1 commit into from Jun 22, 2021

Conversation

mrodozov
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_2_X/gcc700.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

PR21 is adding new files (from PR20)

@mrodozov
Copy link
Contributor Author

please test
lets check it

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f247d8/16134/summary.html
COMMIT: 9e07474
CMSSW: CMSSW_10_2_X_2021-06-20-0000/slc6_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7050/16134/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007546
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007352
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 28 edm output root files, 31 DQM output files
  • TriggerResults: no differences found

@mrodozov
Copy link
Contributor Author

assign generators

@cmsbuild
Copy link
Contributor

New categories assigned: generators

@mkirsano,@SiewYan,@alberto-sanchez,@agrohsje,@GurpreetSinghChahal you have been requested to review this Pull request/Issue and eventually sign? Thanks

@mrodozov
Copy link
Contributor Author

please see
cms-data/GeneratorInterface-EvtGenInterface#20 for details

@agrohsje
Copy link

Hi @mrodozov you mean cms-data/GeneratorInterface-EvtGenInterface#21 and not cms-data/GeneratorInterface-EvtGenInterface#20 ? i.e. you start from the old tag, add marias files, but omit the other changes from alberto which are part of #20.

@mrodozov
Copy link
Contributor Author

mrodozov commented Jun 22, 2021

The details/comments about the change are in 20, 21 is the technical change itself.
I started from 02-00-11 , added only whats inside PR20 and omitted everything in between
you can see the description:
cms-data/GeneratorInterface-EvtGenInterface#21 (comment)

@agrohsje
Copy link

Let's wait for @mgratti to provide feedback on the question from @alberto-sanchez about the BR normalization.

@mgratti
Copy link

mgratti commented Jun 22, 2021

@agrohsje, the question was answered, see cms-data/GeneratorInterface-EvtGenInterface#21 (comment)

@agrohsje
Copy link

agrohsje commented Jun 22, 2021

+generators
Sorry. Following exo meeting.

@mrodozov
Copy link
Contributor Author

ping

@mrodozov
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_2_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 22, 2021

+1

@cmsbuild cmsbuild merged commit 79420bf into IB/CMSSW_10_2_X/gcc700 Jun 22, 2021
@mgratti
Copy link

mgratti commented Jun 22, 2021

hi @silviodonato, @dpiparo, @qliphy, I would like to ask for the building of a release 102_X with the modifications of this PR included. Together with recent modifications in cmssw (#33815), the release should allow to test and eventually inject the MC production of heavy long-lived neutrinos from a B semi-leptonic decays.
Please, let me know in case this type of request should be addressed in a different form. Thank you.

@qliphy
Copy link
Contributor

qliphy commented Jun 23, 2021

@mgratti
Copy link

mgratti commented Jun 23, 2021

@qliphy , thanks a lot

@agrohsje
Copy link

And requested to be included in mc production. @mgratti

@smuzaffar smuzaffar deleted the mrodozov-patch-3 branch June 25, 2021 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants