Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCRAM] Update to support generating multiple tests using single command #7056

Merged
merged 5 commits into from Jun 24, 2021

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Jun 23, 2021

SCRAMV3 now supports to generate multiple unit tests using single command. The format to define multiple tests is

<test name="FOO${loop}" command="echo Foo ${loop}" loop="start,stop,step">
  <flags PRE_TEST="RunMeFirst"/>
</test>

e.g.

  • To run 5 tests FOO1, FOO2,..., FOO5
<test name="FOO${loop}" command="echo Foo ${loop}" loop="5"/>
  • To run 5 tests FOO6, FOO7,..., FOO10
<test name="FOO${loop}" command="echo Foo ${loop}" loop="6,10"/>
  • To run FOO0, FOO5, FOO10,..., FOO100
<test name="FOO${loop}" command="echo Running Foo${loop} for item number ${loop}" loop="0,100,5"/>

@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #7056 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #7056 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #7056 was updated.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97dcfe/16205/summary.html
COMMIT: 3010c5e
CMSSW: CMSSW_12_0_X_2021-06-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7056/16205/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97dcfe/16205/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97dcfe/16205/git-merge-result

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-23-1100/src/FWCore/Framework/test/test_catch2_main.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-23-1100/src/FWCore/Framework/test/test_catch2notTP_ESRecordsToProxyIndices.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-23-1100/src/FWCore/Framework/test/test_catch2notTP_MergeableRunProductMetadata.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-23-1100/src/FWCore/Framework/test/test_catch2notTP_ESRecordsToProxyIndices.cc:1:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-23-1100/src/FWCore/Framework/test/test_catch2notTP_ESRecordsToProxyIndices.cc: In function 'void ____C_A_T_C_H____T_E_S_T____0()':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-23-1100/src/FWCore/Framework/test/test_catch2notTP_ESRecordsToProxyIndices.cc:87:23: error: comparison of integer expressions of different signedness: 'unsigned int' and 'edm::ESProxyIndex::Value_t' {aka 'int'} [-Werror=sign-compare]
   87 |         REQUIRE(index == r2pi.indexInRecord(pr.first, dk).value());
      |                 ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: some warnings being treated as errors
gmake: *** [tmp/slc7_amd64_gcc900/src/FWCore/Framework/test/TestFWCoreFrameworkCatch2notTP/test_catch2notTP_ESRecordsToProxyIndices.cc.o] Error 1
>> Building binary TestFWCoreFrameworkCatch2notTP


@smuzaffar
Copy link
Contributor Author

smuzaffar commented Jun 23, 2021

please test with cms-sw/cmssw#34230 for CMSSW_12_0_X

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmssw#34230

@cmsbuild
Copy link
Contributor

Pull request #7056 was updated.

@smuzaffar
Copy link
Contributor Author

+externals
unit test failure is not related to this PR ( italready failing in IB cms-sw/cmssw#34223 )

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97dcfe/16216/summary.html
COMMIT: d18f596
CMSSW: CMSSW_12_0_X_2021-06-23-1600/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7056/16216/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test_PixelBaryCentreTool had ERRORS

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1264 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785631
  • DQMHistoTests: Total failures: 3669
  • DQMHistoTests: Total nulls: 19
  • DQMHistoTests: Total successes: 2781921
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -45.703 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar deleted the smuzaffar-patch-10 branch June 25, 2021 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants