Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove python2 bindings from opencv and llvm #7095

Merged
merged 2 commits into from Jul 4, 2021

Conversation

smuzaffar
Copy link
Contributor

Reverts #7094

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Jul 2, 2021

test parameters:

  • addpkg = CondFormats,CondCore,DataFormats

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2021

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_0_X/master.

@smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@davidlange6
Copy link
Contributor

davidlange6 commented Jul 2, 2021 via email

@smuzaffar
Copy link
Contributor Author

I already did ( #7094 ) . #7095 is re-revert :-)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2021

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-011cc5/16424/summary.html
COMMIT: 54d6064
CMSSW: CMSSW_12_0_X_2021-07-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7095/16424/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-011cc5/16424/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-011cc5/16424/git-merge-result

Build

I found compilation error when building:

ImportError: No module named clang.cindex
gmake: *** [tmp/slc7_amd64_gcc900/src/CondFormats/GBRForest/src/CondFormatsGBRForest/a/Serialization.cc] Error 1
>> Compiling LCG dictionary: tmp/slc7_amd64_gcc900/src/CondFormats/GBRForest/src/CondFormatsGBRForest/a/CondFormatsGBRForest_xr.cc
Entering library rule at CondFormats/GBRForest
>> Compiling  tmp/slc7_amd64_gcc900/src/CondFormats/GBRForest/src/CondFormatsGBRForest/a/Serialization.cc
c++: error: tmp/slc7_amd64_gcc900/src/CondFormats/GBRForest/src/CondFormatsGBRForest/a/Serialization.cc: No such file or directory
c++: fatal error: no input files
compilation terminated.
c++: error: tmp/slc7_amd64_gcc900/src/CondFormats/GBRForest/src/CondFormatsGBRForest/a/Serialization.cc: No such file or directory
c++: fatal error: no input files
compilation terminated.


@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2021

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-011cc5/16432/summary.html
COMMIT: 54d6064
CMSSW: CMSSW_12_0_X_2021-07-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7095/16432/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-011cc5/16432/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-011cc5/16432/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test test_PixelBaryCentreTool had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785711
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2785688
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

+externals
but this should be integrated after or with cms-sw/cmssw#34323

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2021

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2021

Pull request #7095 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2021

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-011cc5/16447/summary.html
COMMIT: 56e697f
CMSSW: CMSSW_12_0_X_2021-07-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7095/16447/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-011cc5/16447/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-011cc5/16447/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test test_PixelBaryCentreTool had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785924
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2785889
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar merged commit a7139f1 into IB/CMSSW_12_0_X/master Jul 4, 2021
@smuzaffar smuzaffar deleted the revert-7094-revert-7093-dl210702 branch July 9, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants