Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tag for DataFormats-PatCandidates to V01-01-00 #7203

Conversation

cmsbuild
Copy link
Contributor

@cmsbuild cmsbuild commented Aug 5, 2021

Move DataFormats-PatCandidates data to new tag, see
cms-data/DataFormats-PatCandidates#2

This contained modified files, so it should be merged along with cms-sw/cmssw#34446

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Aug 5, 2021

A new Pull Request was created by @cmsbuild for branch IB/CMSSW_12_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.
cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Aug 5, 2021

This contained modified files, so it should be merged along with cms-sw/cmssw#34446

I think that the updates are backward compatible and can be merged first.
I will start the tests

@slava77
Copy link
Contributor

slava77 commented Aug 5, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Aug 5, 2021

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-62fca8/17575/summary.html
COMMIT: f2e32e2
CMSSW: CMSSW_12_1_X_2021-08-05-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7203/17575/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

build-cms+data-DataFormats-PatCandidates+V01-01-00-f5e334720bb3b70a18f3ccc990444014
* The action "build-cms+cmssw-tool-conf+50.0-4cbb59b43389d3cb06120719a0a241da" was not completed successfully because The following dependencies could not complete:
install-cms+cmsswdata+40.0-ece12097a872dc7176d598d8547e81f8
* The action "build-cms+data-DataFormats-PatCandidates+V01-01-00-f5e334720bb3b70a18f3ccc990444014" was not completed successfully because Failed to build data-DataFormats-PatCandidates. Log file in /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/cms/data-DataFormats-PatCandidates/V01-01-00-f5e334720bb3b70a18f3ccc990444014/log. Final lines of the log file:
warning: Macro %rpmbuild_libdir defined but not used within scope
error: No "Source:" tag in the spec file

* The action "install-cms+cmssw-tool-conf+50.0-4cbb59b43389d3cb06120719a0a241da" was not completed successfully because The following dependencies could not complete:
build-cms+cmssw-tool-conf+50.0-4cbb59b43389d3cb06120719a0a241da


@slava77
Copy link
Contributor

slava77 commented Aug 5, 2021

@smuzaffar
I wasn't expecting this type of error

warning: Macro %rpmbuild_libdir defined but not used within scope
error: No "Source:" tag in the spec file

was something missing in the "please test" arguments?

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Aug 5, 2021

Pull request #7203 was updated.

@smuzaffar
Copy link
Contributor

please test
there was an old data/data-DataFormats-PatCandidates.file which was causing this build error. I have removed it.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Aug 5, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-62fca8/17582/summary.html
COMMIT: 47d4cf5
CMSSW: CMSSW_12_1_X_2021-08-05-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7203/17582/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2999410
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2999387
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link
Contributor

slava77 commented Aug 5, 2021

Reco comparison results: 0 differences found in the comparisons

as expected, this can be merged first

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit ae2a7b0 into IB/CMSSW_12_1_X/master Aug 5, 2021
@cmsbuild
Copy link
Contributor Author

cmsbuild commented Aug 5, 2021

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants