Add the cuda-compatible-runtime test as a new external #7279
Conversation
|
please test |
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_12_1_X/master. @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks. |
| cp %_builddir/build/cuda-compatible-runtime %{i}/test/cuda-compatible-runtime | ||
| else | ||
| ln -s /usr/bin/false %{i}/test/cuda-compatible-runtime | ||
| fi |
There was a problem hiding this comment.
@fwyzard , I do not understand this logic here. This is run on the build machine, so if it fails to build then what does that mean?
There was a problem hiding this comment.
It could be a system for which we don't have a CUDA version working (e.g. GCC 12 when it comes out, and before CUDA is updated for it).
If that happens, I thought it safer not to make the build fail, and just replace the script used for the check with something that will always fail (e.g. /usr/bin/false).
There was a problem hiding this comment.
Good news: the link to /usr/bin/false' works as intended.
Bad news: building the cuda-compatible-runtime binary failed on what should be a supported architecture :-(
Is there a way to access the build logs for this PR ?
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah... the sources on gitlab are redirecting to the login page :-(
How do I make cmsbuild log in ?
There was a problem hiding this comment.
ah this is coming from a private repo. Can we move the test.c to come public repo? Though the cmsbuild user has valid krb5 token but as you are downloading a single file using https protocol and that requires username/password. I do not know if there is a gitlab url which can use krb5 token to download a single file
There was a problem hiding this comment.
I think I found a way to make it work, now I'm working through a couple other issues...
fwyzard
force-pushed
the
IB/CMSSW_12_1_X/master_add_cuda-compatible-runtime_external
branch
from
caa1a03
to
293dd8e
Compare
|
please test |
|
Pull request #7279 was updated. |
cuda-compatible-runtime.spec
Outdated
| %define branch master | ||
| %define commit 18d5a51bfb32fbb7b765dd2eecd14e193cce8126 | ||
|
|
||
| Source: git+https://:@gitlab.cern.ch:8443/cms-patatrack/%{n}.git?obj=%{branch}/%{commit}&export=%{n}&filter=test.c&output=/%{n}-%{realversion}.tgz |
There was a problem hiding this comment.
this still means that only users with read access to this repo can build this external ... right ? This will stop other users to build externals
There was a problem hiding this comment.
please change the filter=test.c to filter=./test.c . cmsBuild uses https://github.com/cms-sw/pkgtools/blob/V00-32-XX/cmsBuild#L531 to filter the files which means they will have ./ infront
|
All CMS members should have access.
|
fwyzard
force-pushed
the
IB/CMSSW_12_1_X/master_add_cuda-compatible-runtime_external
branch
from
293dd8e
to
40eb66c
Compare
|
please test |
|
Pull request #7279 was updated. |
|
If this works, the next step would be to replace |
|
@fwyzard , to update |
|
Done. |
fwyzard
force-pushed
the
IB/CMSSW_12_1_X/master_add_cuda-compatible-runtime_external
branch
from
40eb66c
to
9a9f0c3
Compare
|
Pull request #7279 was updated. |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a8f2f/18437/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
|
+externals |
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
externals-approved
fully-signed
and removed
externals-pending
pending-signatures
labels
fwyzard
deleted the
IB/CMSSW_12_1_X/master_add_cuda-compatible-runtime_external
branch
No description provided.