Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UTM to 0.9.1 #7281

Merged
merged 4 commits into from Sep 20, 2021
Merged

Update UTM to 0.9.1 #7281

merged 4 commits into from Sep 20, 2021

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Sep 8, 2021

@mrodozov
Copy link
Contributor Author

mrodozov commented Sep 8, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2021

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_12_1_X/master.

@smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2021

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd9bb3/18386/summary.html
COMMIT: 19c4e98
CMSSW: CMSSW_12_1_X_2021-09-07-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7281/18386/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

+ XERCES_C_BASE=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/xerces-c/3.1.3-bcolbf2
+ export BOOST_BASE=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/boost/1.75.0-4dcdf77cd0ccaa05d4e88c0f252cf522
+ BOOST_BASE=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/boost/1.75.0-4dcdf77cd0ccaa05d4e88c0f252cf522
+ make -j 16 all
make: *** No rule to make target 'all'.  Stop.
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.O0V4rI (%build)


RPM build errors:
Macro %rpmbuild_libdir defined but not used within scope
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.O0V4rI (%build)


@mrodozov
Copy link
Contributor Author

mrodozov commented Sep 8, 2021

@rekovic
a odd problem appeared when building the latest utm. if I build it with
make -j 16 all
it fails (every time) with this:
https://stackoverflow.com/questions/5713894/file-not-recognized-file-truncated-gcc-error
but when I built with
make all
it builds fine. I suspect something in the dependencies is asking to link against a lib that is not yet built, while building another one (it's a guess)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2021

Pull request #7281 was updated.

@mrodozov
Copy link
Contributor Author

mrodozov commented Sep 8, 2021

please test

@smuzaffar
Copy link
Contributor

@mrodozov , we should not drop the parallel build option. please report the issue to UTM developers so that they can fix it. looks like the make files are missing some dependency rules

@mrodozov
Copy link
Contributor Author

mrodozov commented Sep 8, 2021

we should not drop the parallel build option

agree, the test is only for integration purposes. I'll be asking utm devs if they can fix it (and not merge it before they do)

@mrodozov
Copy link
Contributor Author

mrodozov commented Sep 8, 2021

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd9bb3/18402/summary.html
COMMIT: 82178dd
CMSSW: CMSSW_12_1_X_2021-09-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7281/18402/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3001001
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3000973
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

hold
fix needed in order to build utm in parallel

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2021

Pull request has been put on hold by @smuzaffar
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Sep 8, 2021
@arnobaer
Copy link

Issue should be fixed in patch 0.9.1, see
https://gitlab.cern.ch/cms-l1t-utm/utm/-/tags/utm_0.9.1

@mrodozov mrodozov changed the title Update UTM to 0.9.0 Update UTM to 0.9.1 Sep 17, 2021
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd9bb3/18709/summary.html
COMMIT: 2ddc1d9
CMSSW: CMSSW_12_1_X_2021-09-17-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7281/18709/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd9bb3/18709/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd9bb3/18709/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000833
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3000805
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

unhold

@cmsbuild cmsbuild removed the hold label Sep 20, 2021
@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd9bb3/18749/summary.html
COMMIT: 2ddc1d9
CMSSW: CMSSW_12_1_X_2021-09-19-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7281/18749/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 3211080
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211058
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit b5ba2ad into IB/CMSSW_12_1_X/master Sep 20, 2021
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@dildick
Copy link

dildick commented Sep 27, 2021

@smuzaffar Would this also be backported to CMSSW_12_0_X?

@mrodozov
Copy link
Contributor Author

mrodozov commented Sep 27, 2021

backported in
#7337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UTM library 0.9.0 for hadronic showers in GT
5 participants