Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Geant4 to 10.7.2 #7316

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Update Geant4 to 10.7.2 #7316

merged 1 commit into from
Sep 20, 2021

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Sep 16, 2021 •
edited
Loading

At PPD general meeting https://indico.cern.ch/event/1071293/ it was concluded that validation campaign for 10.7p02 is completed with success . It was agreed to use this version for 12_1_X.
It is not assumed to be regression in tests.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for branch IB/CMSSW_12_1_X/master.

@cmsbuild, @smuzaffar, @iarspider, @mrodozov can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor

please test
there is a 10.7.2 tag on github, so lets test it :)

@mrodozov
Copy link
Contributor

abort

@mrodozov
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b75a8/18692/summary.html
COMMIT: 824fce1
CMSSW: CMSSW_12_1_X_2021-09-16-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7316/18692/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 55376 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000833
  • DQMHistoTests: Total failures: 290473
  • DQMHistoTests: Total nulls: 242
  • DQMHistoTests: Total successes: 2710096
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.054 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.310 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.123 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.133 KiB SiStrip/MechanicalView
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: found differences in 13 / 38 workflows

@mrodozov
Copy link
Contributor

@civanch there are a lot of comparison diffs this will need validation

@civanch
Copy link
Contributor Author

civanch commented Sep 17, 2021

@mrodozov , validation campaign was done by PdmV and at https://indico.cern.ch/event/1071293/ they accept.

@smuzaffar
Copy link
Contributor

+externals
@qliphy @perrotta , feel free to integrate this ( Geant4 version 4.7.2) for 12.1.X

@smuzaffar
Copy link
Contributor

please test for slc7_amd64_gcc10

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

please test for slc7_amd64_gcc11

@smuzaffar
Copy link
Contributor

please test for slc7_ppc64le_gcc9

@smuzaffar
Copy link
Contributor

please test for slc7_aarch64_gcc9

@smuzaffar
Copy link
Contributor

please test for cc8_amd64_gcc9

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b75a8/18717/summary.html
COMMIT: 824fce1
CMSSW: CMSSW_12_1_X_2021-09-15-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7316/18717/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Building  edm plugin tmp/slc7_amd64_gcc11/src/Calibration/HcalCalibAlgos/plugins/CalibrationHcalCalibAlgosPlugins/libCalibrationHcalCalibAlgosPlugins.so
/cvmfs/cms-ib.cern.ch/nweek-02698/slc7_amd64_gcc11/external/gcc/11.2.1-23cd49debd041d313975388acecf4b88/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc11/src/Calibration/HcalCalibAlgos/plugins/CalibrationHcalCalibAlgosPlugins/HOCalibAnalyzer.cc.o: in function `HOCalibAnalyzer::HOCalibAnalyzer(edm::ParameterSet const&)':
HOCalibAnalyzer.cc:(.text+0x5935): undefined reference to `HOCalibAnalyzer::nphimx'
/cvmfs/cms-ib.cern.ch/nweek-02698/slc7_amd64_gcc11/external/gcc/11.2.1-23cd49debd041d313975388acecf4b88/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc11/src/Calibration/HcalCalibAlgos/plugins/CalibrationHcalCalibAlgosPlugins/HOCalibAnalyzer.cc.o: in function `HOCalibAnalyzer::HOCalibAnalyzer(edm::ParameterSet const&)':
HOCalibAnalyzer.cc:(.text+0x7315): undefined reference to `HOCalibAnalyzer::nphimx'
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc11/src/Calibration/HcalCalibAlgos/plugins/CalibrationHcalCalibAlgosPlugins/libCalibrationHcalCalibAlgosPlugins.so] Error 1
Leaving library rule at src/Calibration/HcalCalibAlgos/plugins
Entering library rule at Calibration/HcalCalibAlgos
>> Building LCG reflex dict from header file src/Calibration/HcalCalibAlgos/src/classes.h
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-15-1100/src/Calibration/HcalCalibAlgos/src/HcalConstantsXMLWriter.cc

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b75a8/18719/summary.html
COMMIT: 824fce1
CMSSW: CMSSW_12_1_X_2021-09-16-2300/slc7_aarch64_gcc9
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7316/18719/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b75a8/18719/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b75a8/18719/git-merge-result

@cmsbuild
Copy link
Contributor

+1

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 55875 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000833
  • DQMHistoTests: Total failures: 297212
  • DQMHistoTests: Total nulls: 245
  • DQMHistoTests: Total successes: 2703354
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.227 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.192 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.410 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.379 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: found differences in 12 / 38 workflows

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b75a8/18718/summary.html
COMMIT: 824fce1
CMSSW: CMSSW_12_1_X_2021-09-16-2300/cc8_amd64_gcc9
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7316/18718/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b75a8/18718/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b75a8/18718/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 57261 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000833
  • DQMHistoTests: Total failures: 303194
  • DQMHistoTests: Total nulls: 240
  • DQMHistoTests: Total successes: 2697377
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -2.779 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.480 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 136.874 ): -0.023 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): -0.521 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.250 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 4.53 ): 0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 7.3 ): -2.009 KiB SiStrip/MechanicalView
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: found differences in 12 / 38 workflows

@civanch
Copy link
Contributor Author

civanch commented Sep 18, 2021

Problem with "HOCalibAnalyzer::nphimx undefined" at gcc11 does not connect with this PR, only may be in sense that simulation histories is changed and the bug become visible. If it is new than we should make a new issue, if known - ignore.

@qliphy
Copy link
Contributor

qliphy commented Sep 18, 2021 •
edited
Loading

Problem with "HOCalibAnalyzer::nphimx undefined" at gcc11 does not connect with this PR, only may be in sense that simulation histories is changed and the bug become visible. If it is new than we should make a new issue, if known - ignore.

This should be related to cms-sw/cmssw#35240 (comment) and a fix has already been provided: cms-sw/cmssw#35282

The test was with CMSSW: CMSSW_12_1_X_2021-09-15-1100/slc7_amd64_gcc11
However, #35282 was included after CMSSW_12_1_X_2021-09-15-1100
We can just test again with new IB.

@qliphy
Copy link
Contributor

qliphy commented Sep 18, 2021

please test for slc7_amd64_gcc11

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b75a8/18731/summary.html
COMMIT: 824fce1
CMSSW: CMSSW_12_1_X_2021-09-15-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7316/18731/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Building  edm plugin tmp/slc7_amd64_gcc11/src/Calibration/HcalCalibAlgos/plugins/CalibrationHcalCalibAlgosPlugins/libCalibrationHcalCalibAlgosPlugins.so
/cvmfs/cms-ib.cern.ch/nweek-02698/slc7_amd64_gcc11/external/gcc/11.2.1-23cd49debd041d313975388acecf4b88/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc11/src/Calibration/HcalCalibAlgos/plugins/CalibrationHcalCalibAlgosPlugins/HOCalibAnalyzer.cc.o: in function `HOCalibAnalyzer::HOCalibAnalyzer(edm::ParameterSet const&)':
HOCalibAnalyzer.cc:(.text+0x5935): undefined reference to `HOCalibAnalyzer::nphimx'
/cvmfs/cms-ib.cern.ch/nweek-02698/slc7_amd64_gcc11/external/gcc/11.2.1-23cd49debd041d313975388acecf4b88/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc11/src/Calibration/HcalCalibAlgos/plugins/CalibrationHcalCalibAlgosPlugins/HOCalibAnalyzer.cc.o: in function `HOCalibAnalyzer::HOCalibAnalyzer(edm::ParameterSet const&)':
HOCalibAnalyzer.cc:(.text+0x7315): undefined reference to `HOCalibAnalyzer::nphimx'
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc11/src/Calibration/HcalCalibAlgos/plugins/CalibrationHcalCalibAlgosPlugins/libCalibrationHcalCalibAlgosPlugins.so] Error 1
Leaving library rule at src/Calibration/HcalCalibAlgos/plugins
Entering library rule at Calibration/HcalCalibAlgos
>> Building LCG reflex dict from header file src/Calibration/HcalCalibAlgos/src/classes.h
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-15-1100/src/Calibration/HcalCalibAlgos/src/HcalConstantsXMLWriter.cc

@qliphy
Copy link
Contributor

qliphy commented Sep 19, 2021

For slc7_amd64_gcc11 we don't have newer IB than CMSSW_12_1_X_2021-09-15-1100
@smuzaffar Can you make a new IB?
Or as the issue is known, we can also merge this PR if there is no further comment.

@civanch
Copy link
Contributor Author

civanch commented Sep 19, 2021

@qliphy , it seems to me that the problem with gcc11 build has nothing to do with Geant4. If needed, a new issue may be created and this PR may be merged.

@mrodozov
Copy link
Contributor

test parameters:

  • full_cmssw = true

@mrodozov
Copy link
Contributor

please test for slc7_amd64_gcc11

@smuzaffar
Copy link
Contributor

@qliphy , we build gcc11 IBs only few times a week, although I have started an gcc11 IB now but as @mrodozov has already started the test to test this PR with full cmssw so the build error should go away

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b75a8/18744/summary.html
COMMIT: 824fce1
CMSSW: CMSSW_12_1_X_2021-09-15-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7316/18744/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b75a8/18744/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b75a8/18744/git-merge-result

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 57352 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000833
  • DQMHistoTests: Total failures: 355332
  • DQMHistoTests: Total nulls: 279
  • DQMHistoTests: Total successes: 2645200
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 41.89 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.117 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
  • DQMHistoSizes: changed ( 250202.181 ): 0.059 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.244 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 7.3 ): -3.995 KiB SiStrip/MechanicalView
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: found differences in 12 / 38 workflows

@smuzaffar
Copy link
Contributor

gcc11 PR tests now look good, feel free to update Geant4 10.7.2 for CMSSW_12_1_X

@qliphy
Copy link
Contributor

qliphy commented Sep 20, 2021

+1

@cmsbuild cmsbuild merged commit 85bbdbb into cms-sw:IB/CMSSW_12_1_X/master Sep 20, 2021
This was referenced Sep 20, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@civanch @cmsbuild @mrodozov @smuzaffar @qliphy