Run3-alca200 Bug fix to 2 classes in Calibration/HcalCalibAlgos

[bsunanda]

PR description:

Bug fix to 2 classes in Calibration/HcalCalibAlgos

PR validation:

Tasing the code privately

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35282/25283

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Calibration/HcalCalibAlgos (alca)

@yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild please test

[qliphy]

please test for slc7_amd64_gcc10

[qliphy]

urgent
#35279 (comment)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21a402/18622/summary.html
COMMIT: 96bd131
CMSSW: CMSSW_12_1_X_2021-09-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35282/18622/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @thomreis ECAL esConsumes migration of remaining file in RecoMET #35179
• @yuanchao Remove unused headers for RECO & SIM packages #35167
• @bsunanda Run3-alca199 Split HOCalibAnalyzer.cc to take out the post analysis part in separate macros #35240
• @mmusich modernize SiStripDetInfoFileWriter #35265
• @Dr15Jones Added esConsumes to HBHERecHitProducerGPU #35228
• @Dr15Jones Change current path in cmsExternalGenerator not cmsRun #35253
• @thomreis ECAL esConsumes migration of CalibCalorimetry packages #35077
• @bsunanda Run3-hcx320 Use of ESGetToken in RecoLocalCalo/HcalRecAlgos (replacing #35234) #35241
• @guitargeek Clean unused dependencies from BuildFiles #35215
• @Dr15Jones Added esConsumes calls to code in RecoLocalMuon #35184
• @mmusich fix undefined behavior in MultiTrackValidator #35086
• @mmusich Alignment/OfflineValidation improvements from CRUZET'21 data analysis #35266
• @Dr15Jones Finish esConsumes migration for L1TMuonBarrelTrackProducer #35095

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21a402/18622/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21a402/18622/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000833
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3000799
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[tvami]

type bug-fix

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[tvami]

Also congrats @bsunanda on the 200th AlCa PR 💯

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21a402/18623/summary.html
COMMIT: 96bd131
CMSSW: CMSSW_12_1_X_2021-09-13-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35282/18623/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @makortel Set numberOfConcurrentLuminosityBlocks to 1 for GEN steps that have EDModules that are not going to support concurrent lumis #35182
• @Dr15Jones Added esConsumes calls to code in RecoLocalMuon #35184
• @yuanchao Remove unused headers for RECO & SIM packages #35167
• @apsallid [HGCAL] Updates on validation scripts  #35239
• @Dr15Jones Added missing esConsumes to DTTrackFinder #35080
• @mmusich fix undefined behavior in MultiTrackValidator #35086
• @mmusich Miscellaneous graphical payload inspector fixes #35244
• @bsunanda Run3-hcx320 Use of ESGetToken in RecoLocalCalo/HcalRecAlgos (replacing #35234) #35241
• @bsunanda Run3-alca199 Split HOCalibAnalyzer.cc to take out the post analysis part in separate macros #35240
• @guitargeek Clean unused dependencies from BuildFiles #35215
• @sroychow Migrate CondTools-Ecal modules to use esconsumes #35079
• @thomreis ECAL esConsumes migration of remaining file in RecoMET #35179
• @archiron /validation/RecoEgamma PHASE2 modifications #35192
• @mmusich modernize SiStripDetInfoFileWriter #35265
• @Dr15Jones Added esConsumes to HBHERecHitProducerGPU #35228
• @ahinzmann Unify vertex association between CHS and PUPPI #33885
• @mmusich Alignment/OfflineValidation improvements from CRUZET'21 data analysis #35266
• @Dr15Jones Finish esConsumes migration for L1TMuonBarrelTrackProducer #35095
• @thomreis ECAL esConsumes migration of CalibCalorimetry packages #35077
• @Dr15Jones Change current path in cmsExternalGenerator not cmsRun #35253
• @mmusich modernize Alignment/TrackerAlignment #35254
• @sroychow Migrate Condtools-DT modules to esConsumes #35023

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21a402/18623/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21a402/18623/git-merge-result

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 56306 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000833
• DQMHistoTests: Total failures: 202384
• DQMHistoTests: Total nulls: 30
• DQMHistoTests: Total successes: 2798397
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -89.75 KiB( 38 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): -1.066 KiB EgammaV/ElectronMcSignalValidatorPt1000
• DQMHistoSizes: changed ( 10024.0,... ): -1.043 KiB EgammaV/ElectronMcSignalValidator
• DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
• DQMHistoSizes: changed ( 250202.181 ): -0.064 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.308 KiB SiStrip/MechanicalView
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: found differences in 13 / 38 workflows

[tvami]

test parameters:

• release = slc7_amd64_gcc10

[tvami]

• DQMHistoTests: Total failures: 202384

This is a lot of changes, maybe we should re-trigger tests?

[tvami]

on the other hand, the code did compile in slc7_amd64_gcc10 so the issue is fixed...

[tvami]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• The fix is necessary