Test if yoda_pyroot.patch is still necessary (after dropping Py2)

[iarspider]

No description provided.

[iarspider]

please test

[cmsbuild]

A new Pull Request was created by @iarspider for branch IB/CMSSW_12_1_X/master.

@smuzaffar, @iarspider, @mrodozov can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

[davidlange6]

this patch has nothing to do with python2 vs 3.. I'm not sure that the Yoda python interface is tested so its not obvious that a positive test result is sufficient to conclude that this patch is not needed...

[smuzaffar]

To support py2/3 in root, here was what was suggested by root team

As a follow up of our discussion a couple of weeks ago, we've been
working with Massimiliano on this PR (not merged yet):

https://github.com/root-project/root/pull/5083

The highlights are:
- We will place all the libs (included the PyROOT ones) in the
ROOTSYS/lib directory, instead of using subdirectories for each Python
version. The PyROOT libraries will have the version number in the
library name, e.g. libcppyy2_7.so, to allow to build for both Python2
and Python3 at the same time. This solves the problem of having
duplicate library names when symlinking everything into the lib of CMSSW.
- We will only generate one libTPython.so. The reason is the PCMs: we
can't have libTPython2_7.so and libTPython3_6.so, plus their respective
PCMs, because all the PCMs are loaded by ROOT and we would have
duplicated symbols.
- To solve the Yoda case, we propose that Yoda does not link anymore
against libTPython, but against libcppyy. libcppyy contains the
functionality that Yoda needs, it is just a matter of including a
different header and slightly changing the function names that are being
invoked (we can give you more details about this). libcppyy will have
two versions (e.g. libcppyy2_7 and libcppyy3_6), so Yoda will be able to
be used from both Pythons. 

I think without this patch yoda was even failing to build

[smuzaffar]

please test for CMSSW_12_1_ROOT6_X

[davidlange6]

interesting... thanks for the correction. It seems however that this change might be desirable in any case, but indeed better for the Yoda team to maintain that.

…

On Oct 4, 2021, at 11:33 AM, Malik Shahzad Muzaffar ***@***.***> wrote: To support py2/3 in root, here was what was suggested by root team As a follow up of our discussion a couple of weeks ago, we've been working with Massimiliano on this PR (not merged yet): root-project/root#5083 The highlights are: - We will place all the libs (included the PyROOT ones) in the ROOTSYS/lib directory, instead of using subdirectories for each Python version. The PyROOT libraries will have the version number in the library name, e.g. libcppyy2_7.so, to allow to build for both Python2 and Python3 at the same time. This solves the problem of having duplicate library names when symlinking everything into the lib of CMSSW. - We will only generate one libTPython.so. The reason is the PCMs: we can't have libTPython2_7.so and libTPython3_6.so, plus their respective PCMs, because all the PCMs are loaded by ROOT and we would have duplicated symbols. - To solve the Yoda case, we propose that Yoda does not link anymore against libTPython, but against libcppyy. libcppyy contains the functionality that Yoda needs, it is just a matter of including a different header and slightly changing the function names that are being invoked (we can give you more details about this). libcppyy will have two versions (e.g. libcppyy2_7 and libcppyy3_6), so Yoda will be able to be used from both Pythons. I think without this patch yoda was even failing to build — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c40715/19357/summary.html
COMMIT: cb4caec
CMSSW: CMSSW_12_1_X_2021-10-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7355/19357/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 11634.912

----- Begin Fatal Exception 04-Oct-2021 12:51:39 CEST-----------------------
An exception of category 'TrackingTools/PatternTools' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 9 stream: 0
   [1] Running path 'HLT_TrkMu6NoFiltersNoVtx_v1'
   [2] Calling method for module CkfTrackCandidateMaker/'hltIterL3OITrackCandidatesNoVtx'
Exception Message:
Trajectory::check() - information requested from empty Trajectory 
----- End Fatal Exception -------------------------------------------------

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c40715/19374/summary.html
COMMIT: cb4caec
CMSSW: CMSSW_12_1_X_2021-10-04-1300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7355/19374/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3219394
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3219366
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)