Update TBB to 2021.4.0; remove upstreamed patches

[iarspider]

No description provided.

[cmsbuild]

A new Pull Request was created by @iarspider for branch IB/CMSSW_12_1_X/master.

@cmsbuild, @smuzaffar, @iarspider, @ddaina can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

[iarspider]

please test

[smuzaffar]

enable threading

[smuzaffar]

please test

[smuzaffar]

please test for slc7_ppc64le_gcc9

[smuzaffar]

please test for slc7_aarch64_gcc9

[smuzaffar]

please test for cc8_amd64_gcc9

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-373b73/19504/summary.html
COMMIT: 8288aff
CMSSW: CMSSW_12_1_X_2021-10-07-2300/slc7_ppc64le_gcc9
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7374/19504/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-sw Updated cms-git-tools to include a simple bug fix for git-cms-addpkg #7370

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-373b73/19504/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-373b73/19504/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test test_PrepareInputDb had ERRORS
---> test test_MpsWorkFlow had ERRORS
---> test testFWCoreUtilities had ERRORS
---> test testAlignmentOfflineValidation had ERRORS
and more ...

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-373b73/19502/summary.html
COMMIT: 8288aff
CMSSW: CMSSW_12_1_X_2021-10-08-1100/slc7_amd64_gcc900
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7374/19502/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2798082
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2798054
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-373b73/19503/summary.html
COMMIT: 8288aff
CMSSW: CMSSW_12_1_X_2021-10-07-2300/cc8_amd64_gcc9
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7374/19503/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-sw Updated cms-git-tools to include a simple bug fix for git-cms-addpkg #7370

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-373b73/19503/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-373b73/19503/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 60407 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3219394
• DQMHistoTests: Total failures: 301611
• DQMHistoTests: Total nulls: 256
• DQMHistoTests: Total successes: 2917505
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -2.696 KiB( 39 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.171 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 136.874,... ): 0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 250202.181 ): -0.645 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.117 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 7.3 ): -2.009 KiB SiStrip/MechanicalView
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: found differences in 13 / 39 workflows

[cmsbuild]

-1

Failed Tests: UnitTests RelVals-THREADING
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-373b73/19505/summary.html
COMMIT: 8288aff
CMSSW: CMSSW_12_1_X_2021-10-07-2300/slc7_aarch64_gcc9
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7374/19505/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-sw Updated cms-git-tools to include a simple bug fix for git-cms-addpkg #7370

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-373b73/19505/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-373b73/19505/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestFWCoreServicesDriver had ERRORS

RelVals-THREADING

The relvals timed out after 4 hours.

[smuzaffar]

+externals