Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tag for RecoEgamma-ElectronIdentification to V01-08-00 #7388

Conversation

cmsbuild
Copy link
Contributor

Move RecoEgamma-ElectronIdentification data to new tag, see
cms-data/RecoEgamma-ElectronIdentification#23

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for branch IB/CMSSW_12_1_X/master.

@cmsbuild, @smuzaffar, @iarspider, @ddaina can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

+externals
this has been tested via cms-data/RecoEgamma-ElectronIdentification#23 and contains only new files

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_1_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor Author

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-734b84/19631/summary.html
COMMIT: 294afd3
CMSSW: CMSSW_12_1_X_2021-10-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7388/19631/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 2796107
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2796074
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 39 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

  • Only new files added

@perrotta
Copy link
Contributor

Uhm, I suspect the conflict comes from the contemporary merging of #7389

@smuzaffar
Copy link
Contributor

+externals
I have resolved the conflict. feel free to merge it

@cmsbuild
Copy link
Contributor Author

Pull request #7388 was updated.

@perrotta
Copy link
Contributor

+externals I have resolved the conflict. feel free to merge it

Thank you @smuzaffar

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

merge
(no need to wait for the test results...)

@cmsbuild cmsbuild merged commit 7fd4a49 into IB/CMSSW_12_1_X/master Oct 18, 2021
@cmsbuild
Copy link
Contributor Author

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-734b84/19710/summary.html
COMMIT: 128c408
CMSSW: CMSSW_12_1_X_2021-10-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7388/19710/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-734b84/19710/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-734b84/19710/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 2751113
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2751090
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
  • Checked 170 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants