Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python and py2-future #7492

Merged
merged 3 commits into from Dec 7, 2021
Merged

Remove python and py2-future #7492

merged 3 commits into from Dec 7, 2021

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Dec 7, 2021

This is backport of #7359 (from DEVEL IBs) which remove python2 and python2 based packages
backport of #7359

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2021

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_3_X/master.

@cmsbuild, @smuzaffar, @iarspider, @ddaina can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c06b9/21044/summary.html
COMMIT: 3317585
CMSSW: CMSSW_12_3_X_2021-12-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7492/21044/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c06b9/21044/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c06b9/21044/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250608
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3250580
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

+externals
@qliphy , @perrotta @makortel , this pr drops python2 and last py2 back package from 12.3.X release. This has been in devel IBs for couple of months. Feel free to merge it.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2021

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_3_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Dec 7, 2021

+1

  • The beginning of the 12_3_X cycle is the right moment to merge this

@cmsbuild cmsbuild merged commit 0ac7c2a into IB/CMSSW_12_3_X/master Dec 7, 2021
@smuzaffar smuzaffar deleted the drop-python2 branch December 7, 2021 22:32
@davidlange6
Copy link
Contributor

hi @smuzaffar - the IB of last night has some warnings due to this change

****WARNING: Invalid tool python. Please fix das_client file.
****WARNING: Invalid tool python. Please fix frontier_client file.

@smuzaffar
Copy link
Contributor Author

thanks @davidlange6 , #7501 should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants