Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.6.X] Correctionlib C++ and python2 binding #7523

Merged
merged 2 commits into from Jan 10, 2022

Conversation

nsmith-
Copy link

@nsmith- nsmith- commented Dec 17, 2021

This uses a special Makefile rather than pip because the normal package is python3-only. This build has the C++ evaluator and python2 bindings only. A subset of the high-level wrapper could be backported as well, in principle.

TODO: in my test area, the python2 binding is not available until I run the corresponding ...build/slc7_amd64_gcc700/external/correctionlib/2.1.0-3822e3561f9af87ea18bc53317ea8ebf/etc/profile.d/init.sh. Is there anywhere else I have to add the site package since I am not pip installing in cmsdist? For reference, a sufficient python2 test would be:

import correctionlib._core as cc
cs = cc.CorrectionSet.from_file("/cvmfs/cms.cern.ch/rsync/cms-nanoAOD/jsonpog-integration/POG/EGM/2017_UL/photon.json.gz")
cs["UL-Photon-ID-SF"].evaluate("2017", "sf", "Loose", 1.2, 25.3)

Closes #7510

This uses a special Makefile rather than pip because the normal package
is python3-only. This build has the C++ evaluator and python2 bindings
only. A subset of the high-level wrapper could be backported as well, in
principle.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nsmith- (Nicholas Smith) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @iarspider, @ddaina can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@@ -0,0 +1,18 @@
### RPM external correctionlib 2.1.0
## INITENV +PATH PYTHON27PATH %i/${PYTHON_LIB_SITE_PACKAGES}
%define tag v%{realversion}cms0
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In future releases, the special Makefile will be in the regular release and we can drop the cms0 suffix here.

@cmsbuild
Copy link
Contributor

Pull request #7523 was updated.

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmssw#36547

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b2713/21586/summary.html
COMMIT: d3f4106
CMSSW: CMSSW_10_6_X_2022-01-09-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7523/21586/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215350
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar changed the title Correctionlib C++ and python2 binding for 10_6_X [10.6.X] Correctionlib C++ and python2 binding Jan 10, 2022
@smuzaffar
Copy link
Contributor

+externals
@perrotta @qliphy . feel free to merge this along with cms-sw/cmssw#36547 for 10.6.X

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jan 10, 2022

+1

@cmsbuild cmsbuild merged commit 468b0c9 into cms-sw:IB/CMSSW_10_6_X/gcc700 Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants