New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.6.X] Correctionlib C++ and python2 binding #7523
[10.6.X] Correctionlib C++ and python2 binding #7523
Conversation
This uses a special Makefile rather than pip because the normal package is python3-only. This build has the C++ evaluator and python2 bindings only. A subset of the high-level wrapper could be backported as well, in principle.
A new Pull Request was created by @nsmith- (Nicholas Smith) for branch IB/CMSSW_10_6_X/gcc700. @cmsbuild, @smuzaffar, @iarspider, @ddaina can you please review it and eventually sign? Thanks. |
@@ -0,0 +1,18 @@ | |||
### RPM external correctionlib 2.1.0 | |||
## INITENV +PATH PYTHON27PATH %i/${PYTHON_LIB_SITE_PACKAGES} | |||
%define tag v%{realversion}cms0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In future releases, the special Makefile will be in the regular release and we can drop the cms0
suffix here.
Pull request #7523 was updated. |
please test with cms-sw/cmssw#36547 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b2713/21586/summary.html Comparison SummarySummary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This uses a special Makefile rather than pip because the normal package is python3-only. This build has the C++ evaluator and python2 bindings only. A subset of the high-level wrapper could be backported as well, in principle.
TODO: in my test area, the python2 binding is not available until I run the corresponding
...build/slc7_amd64_gcc700/external/correctionlib/2.1.0-3822e3561f9af87ea18bc53317ea8ebf/etc/profile.d/init.sh
. Is there anywhere else I have to add the site package since I am not pip installing in cmsdist? For reference, a sufficient python2 test would be:Closes #7510