Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT 6.26] Root update v6 26 00 patches 20220203 #7602

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Feb 3, 2022

test parameters:

  • enable_test = threading
  • full_cmssw = true

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2022

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_3_X/rootnext.

@cmsbuild, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2022

Pull request #7602 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2022

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fab7e/22213/summary.html
COMMIT: d5fb65a
CMSSW: CMSSW_12_3_ROOT626_X_2022-02-03-2300/slc7_amd64_gcc10
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7602/22213/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fab7e/22213/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fab7e/22213/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test DRNTest had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16697 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3765022
  • DQMHistoTests: Total failures: 42109
  • DQMHistoTests: Total nulls: 8
  • DQMHistoTests: Total successes: 3722883
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 225.693 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 33.682 KiB GEM/Efficiency
  • DQMHistoSizes: changed ( 11634.0,... ): 1.448 KiB GEM/Digis
  • DQMHistoSizes: changed ( 11634.0,... ): 0.849 KiB GEM/SimHits
  • DQMHistoSizes: changed ( 11634.0,... ): 0.531 KiB GEM/Pad
  • DQMHistoSizes: changed ( 11634.0,... ): 0.432 KiB GEM/PadCluster
  • DQMHistoSizes: changed ( 11634.0,... ): 0.299 KiB GEM/RecHits
  • DQMHistoSizes: changed ( 11834.0 ): 2.249 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 193 log files, 42 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 6 / 45 workflows

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fab7e/22251/summary.html
COMMIT: d5fb65a
CMSSW: CMSSW_12_3_ROOT626_X_2022-02-06-2300/slc7_amd64_gcc10
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7602/22251/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fab7e/22251/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fab7e/22251/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 17346 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3766018
  • DQMHistoTests: Total failures: 42104
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3723890
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.245 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): 2.249 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 193 log files, 42 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 6 / 45 workflows

@smuzaffar
Copy link
Contributor Author

looks good but there are many dqm diff but they are there for a long time now. We need to check which root changes are causes these dqm comparison failure. For now I am merging this to test full run the matrix

@smuzaffar smuzaffar merged commit 058f2a1 into cms-sw:IB/CMSSW_12_3_X/rootnext Feb 7, 2022
@smuzaffar smuzaffar deleted the root-update-v6-26-00-patches-20220203 branch February 7, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants