-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Millepede to V04-11-01 and switch to git #7660
Conversation
please test |
A new Pull Request was created by @iarspider for branch IB/CMSSW_12_3_X/master. @smuzaffar, @iarspider can you please review it and eventually sign? Thanks. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8775e5/22772/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
assign alca Do we still use [a]
|
New categories assigned: alca @yuanchao,@francescobrivio,@malbouis,@tvami you have been requested to review this Pull request/Issue and eventually sign? Thanks |
Hi @smuzaffar , yes MillePede is still used by the tracker alignment group! Let me tag @cms-sw/trk-dpg-l2 for further comments |
that's not correct. There's minimal testing in the relval workflow 1001.0. |
@cms-sw/alca-l2 , can you also please add a unit test for testing |
I will add a simple unit test which just runs |
thanks. In a slightly longer timescale one could think of putting together also a more realistic test which runs |
please test with cms-sw/cmssw#37145 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8775e5/22853/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
@smuzaffar no objections, and thanks for the unit test. I also support making a real test with a small alignment campaign setup as Marco suggested |
|
||
Source: svn://svnsrv.desy.de/public/MillepedeII/tags/%{realversion}/?scheme=http&module=%{realversion}&output=/%{n}-%{realversion}.tgz | ||
### RPM external millepede V04-11-01 | ||
%define tag 9ee817fc61fe3e1b6543a8a16f7bcd8e1f8c331f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iarspider @smuzaffar for my own education from where does this tag come from?
If I look at: https://gitlab.desy.de/claus.kleinwort/millepede-ii/-/tags the tag corresponding to version V04-11-01 is rather 4f288098f84f274f5a241f921035af77bc07d5c8
?
Can you explain?
Thanks
Cc: @consuegs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! I will open a follow-up PR now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmusich , you are right, the commit does not match the tag. @iarspider cn you please fix this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iarspider , do you remember how you ended up using 9ee817fc61fe3e1b6543a8a16f7bcd8e1f8c331f ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I was just browsing history trying to check a few things, and copy-pasted wrong commit.
No description provided.