Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update curl to 7.79.0 #7689

Closed
wants to merge 2 commits into from
Closed

Conversation

iarspider
Copy link
Contributor

No description provided.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_12_4_X/master.

@smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91285e/23098/summary.html
COMMIT: aca3a04
CMSSW: CMSSW_12_4_X_2022-03-13-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7689/23098/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

SHA256 of old file: 0
Downloading certdata.txt ...
curl lacks https support
Falling back to HTTP
URLs other than HTTPS are disabled by default, to enable use -k
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.v1S2y1 (%build)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.v1S2y1 (%build)



@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #7689 was updated.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91285e/23111/summary.html
COMMIT: 6c3e115
CMSSW: CMSSW_12_4_X_2022-03-14-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7689/23111/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test_edmPickEvents had ERRORS
---> test materialBudgetTrackerPlots had ERRORS

Comparison Summary

The workflows 1001.0, 1000.0, 136.88811, 136.874, 136.8311, 136.793, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695377
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695350
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@iarspider
Copy link
Contributor Author

@smuzaffar this is ready for review. Since it's a very low level package, it should probably be held for now.

@smuzaffar
Copy link
Contributor

@smuzaffar this is ready for review. Since it's a very low level package, it should probably be held for now.

right, lets keep this on hold and include it when we do pip/python update

@smuzaffar
Copy link
Contributor

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @smuzaffar
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@smuzaffar
Copy link
Contributor

closing as it has been integrated via #7696

@smuzaffar smuzaffar closed this Mar 18, 2022
@smuzaffar smuzaffar deleted the update/curl-7.79.0 branch March 18, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants