Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.2.X] Millipede to V04-11-01 #7718

Merged
merged 1 commit into from Mar 25, 2022

Conversation

mmusich
Copy link

@mmusich mmusich commented Mar 25, 2022

backport of #7685

I suspect this will cure the issue with the failing test in 12_2_X IBs:

----- Begin Fatal Exception 24-Mar-2022 12:45:07 CET-----------------------
An exception of category 'LogicError' occurred while
   [0] Processing end ProcessBlock
   [1] Calling method for module AlignmentProducerAsAnalyzer/'SiPixelAliPedeAlignmentProducer'
Exception Message:
@SUB=MillePedeFileReader::getStringFromHLS
Found an alignable structure not possible to map in the default AlignPCLThresholds partitions
----- End Fatal Exception -------------------------------------------------

see log at: https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc900/CMSSW_12_2_X_2022-03-24-1100/unitTestLogs/Calibration/TkAlCaRecoProducers#/156

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 25, 2022

A new Pull Request was created by @mmusich (Marco Musich) for branch IB/CMSSW_12_3_X/master.

@cmsbuild, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@mmusich
Copy link
Author

mmusich commented Mar 25, 2022

how can include in the tests, the unit tests from the package Calibration/TkAlCaRecoProducers ?

@mmusich
Copy link
Author

mmusich commented Mar 25, 2022

@perrotta do you know the answer to the question above?

@smuzaffar
Copy link
Contributor

test parameters:

  • addpkg = Calibration/TkAlCaRecoProducers

@smuzaffar
Copy link
Contributor

@mmusich , by setting addpkg test parameter e.g. #7718 (comment)

@mmusich
Copy link
Author

mmusich commented Mar 25, 2022

please test

  • thanks @smuzaffar (I wasn't sure the syntax worked also for cmsdist)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-999658/23382/summary.html
COMMIT: c291031
CMSSW: CMSSW_12_3_X_2022-03-24-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7718/23382/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695161
  • DQMHistoTests: Total failures: 19
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3695119
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals
@qliphy @perrotta feel free to merge it

@perrotta
Copy link
Contributor

+1

  • It seems to work in fixing the issues with the previously failing unit tests

@perrotta
Copy link
Contributor

ping bot

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_3_X/master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit adbafe0 into cms-sw:IB/CMSSW_12_3_X/master Mar 25, 2022
@smuzaffar
Copy link
Contributor

looks like github again has issues. I have force run bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants