Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm] Update to version 14.0.6 #7729

Closed
wants to merge 14 commits into from

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_4_X/master.

@cmsbuild, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_12_4_CLANG_X

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53867e/23473/summary.html
COMMIT: a5f01a9
CMSSW: CMSSW_12_4_CLANG_X_2022-03-27-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7729/23473/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Expectedly Failed:   2
Failed           : 637
FAILED: tools/clang/tools/extra/test/CMakeFiles/check-clang-tools 
cd /pool/condor/dir_63618/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc10/external/llvm/14.0.0-1e54cb1887a6207267482ee7b02b1796/build/tools/clang/tools/extra/test && /pool/condor/dir_63618/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/python3/3.9.6-67e5cf5b4952101922f1d4c8474baa39/bin/python3.9 /pool/condor/dir_63618/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc10/external/llvm/14.0.0-1e54cb1887a6207267482ee7b02b1796/build/./bin/llvm-lit -sv /pool/condor/dir_63618/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc10/external/llvm/14.0.0-1e54cb1887a6207267482ee7b02b1796/build/tools/clang/tools/extra/test
ninja: build stopped: subcommand failed.
error: Bad exit status from /pool/condor/dir_63618/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.dA8D0E (%build)


RPM build errors:
Bad exit status from /pool/condor/dir_63618/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.dA8D0E (%build)



@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53867e/23472/summary.html
COMMIT: a5f01a9
CMSSW: CMSSW_12_4_X_2022-03-28-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7729/23472/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Expectedly Failed:   2
Failed           : 637
FAILED: tools/clang/tools/extra/test/CMakeFiles/check-clang-tools 
cd /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc10/external/llvm/14.0.0-1e54cb1887a6207267482ee7b02b1796/build/tools/clang/tools/extra/test && /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/python3/3.9.6-67e5cf5b4952101922f1d4c8474baa39/bin/python3.9 /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc10/external/llvm/14.0.0-1e54cb1887a6207267482ee7b02b1796/build/./bin/llvm-lit -sv /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc10/external/llvm/14.0.0-1e54cb1887a6207267482ee7b02b1796/build/tools/clang/tools/extra/test
ninja: build stopped: subcommand failed.
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.i3E2ZZ (%build)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.i3E2ZZ (%build)



@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #7729 was updated.

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53867e/23509/summary.html
COMMIT: db2c1ba
CMSSW: CMSSW_12_4_X_2022-03-29-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7729/23509/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Unsupported      :    1
Passed           : 1155
Expectedly Failed:    2
+ bin/clang-tidy '--checks=*' --list-checks
+ grep cms-handle
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.MfOFGq (%build)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.MfOFGq (%build)



@smuzaffar
Copy link
Contributor Author

@gartung , I think cms clang-tidy checks need updates for clang 14.0.0. clang-tidy-checks failed with [a]. I tried to get your changes from https://github.com/cms-externals/llvm-project/commits/cms/release/12.x/fed4134 in to https://github.com/cms-externals/llvm-project/commits/cms/release/14.x/3f43d80 branch. Can you please check and provide a fix. Note that without cms clang-tidy checks these tests passed [b]

[a] https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53867e/23472/external/llvm/14.0.0-1e54cb1887a6207267482ee7b02b1796/log

  Unsupported      :   1
  Passed           : 520
  Expectedly Failed:   2
  Failed           : 637
Running ['clang-tidy', '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc10/external/llvm/14.0.0-1e54cb1887a6207267482ee7b02b1796/build/tools/clang/tools/extra/tes
t/clang-tidy/infrastructure/Output/objc-arc-and-properties.m.tmp.m', '-fix', '--checks=-*,bugprone-suspicious-semicolon', '-config={}', '--', '-fobjc-abi-version=2', '-fobjc-arc', '-fblocks', '-
nostdinc++']...
clang-tidy /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc10/external/llvm/14.0.0-1e54cb1887a6207267482ee7b02b1796/build/tools/clang/tools/extra/test/clang-tidy/
infrastructure/Output/objc-arc-and-properties.m.tmp.m -fix --checks=-*,bugprone-suspicious-semicolon -config={} -- -fobjc-abi-version=2 -fobjc-arc -fblocks -nostdinc++ failed:
2 warnings generated.
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc10/external/llvm/14.0.0-1e54cb1887a6207267482ee7b02b1796/build/tools/clang/tools/extra/test/clang-tidy/infrastruct
ure/Output/objc-arc-and-properties.m.tmp.m:18:22: warning: potentially unintended semicolon [bugprone-suspicious-semicolon]
  if(f.shouldDoStuff); [f nop];
                     ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc10/external/llvm/14.0.0-1e54cb1887a6207267482ee7b02b1796/build/tools/clang/tools/extra/test/clang-tidy/infrastruct
ure/Output/objc-arc-and-properties.m.tmp.m:18:22: note: FIX-IT applied suggested code changes
clang-tidy applied 1 of 1 suggested fixes.
Suppressed 1 warnings (1 with check filters).
*** Error in `clang-tidy': double free or corruption (fasttop): 0x000000000305cf40 ***
======= Backtrace: =========
/lib64/libc.so.6(+0x81329)[0x2b4d80650329]
/lib64/libc.so.6(__cxa_finalize+0x9a)[0x2b4d8060905a]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc10/external/llvm/14.0.0-1e54cb1887a6207267482ee7b02b1796/build/bin/../lib64/libclang-cpp.so.14(+0x9d25d3)[0x2b4d786d15d3]
======= Memory map: ========
00400000-00762000 r--p 00000000 fc:02 1061185659                         /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc10/external/llvm/14.0.0-1e54cb1887a6207267482ee7b02b1796/build/bin/clang-tidy
00762000-02496000 r-xp 00362000 fc:02 1061185659                         /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc10/external/llvm/14.0.0-1e54cb1887a620726

[b] #7729 (comment)

Unsupported      :    1
Passed           : 1155
Expectedly Failed:    2

@gartung
Copy link
Member

gartung commented Mar 30, 2022

@smuzaffar I pushed an update to the cms clang tidy library CMakeLists.txt that I tested locally to work. The new head of the branch is 282462f20845d87aad8e6d55bccc06b3de1ab4d0

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53867e/26884/summary.html
COMMIT: ce5ef22
CMSSW: CMSSW_12_5_X_2022-08-17-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7729/26884/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53867e/26884/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53867e/26884/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test testTauEmbeddingProducers had ERRORS

Comparison Summary

There are some workflows for which there are errors in the baseline:
136.9 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 17552 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3692500
  • DQMHistoTests: Total failures: 23447
  • DQMHistoTests: Total nulls: 4
  • DQMHistoTests: Total successes: 3669027
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.008 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 138.4,... ): -0.004 KiB JetMET/SUSYDQM
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 2 / 50 workflows

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_12_5_CLANG_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53867e/26901/summary.html
COMMIT: ce5ef22
CMSSW: CMSSW_12_5_CLANG_X_2022-08-17-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7729/26901/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53867e/26901/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53867e/26901/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test testCommonToolsUtil had ERRORS
---> test EgammaTowerIso_t had ERRORS

Comparison Summary

Summary:

  • You potentially added 76776 lines to the logs
  • Reco comparison results: 17595 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3692140
  • DQMHistoTests: Total failures: 61438
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3630678
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 975.5440000000001 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 108.078 KiB HLT/EXO
  • DQMHistoSizes: changed ( 11634.0,... ): 54.512 KiB HLT/HIG
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 1 / 50 workflows

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_12_5_X/master to IB/CMSSW_12_6_X/master August 28, 2022 09:07
@smuzaffar
Copy link
Contributor Author

please test for CMSSW_12_4_CLANG_X

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_12_6_CLANG_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2022

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53867e/27252/summary.html
COMMIT: 0814aae
CMSSW: CMSSW_12_6_CLANG_X_2022-08-31-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7729/27252/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53867e/27252/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53867e/27252/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test testCommonToolsUtil had ERRORS
---> test EgammaTowerIso_t had ERRORS

Comparison Summary

Summary:

  • You potentially added 93461 lines to the logs
  • Reco comparison results: 16244 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3620448
  • DQMHistoTests: Total failures: 85504
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3534920
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 1 / 50 workflows

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2022

Pull request #7729 was updated.

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_12_6_CLANG_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2022

-1

Failed Tests: UnitTests AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53867e/27278/summary.html
COMMIT: 028a67c
CMSSW: CMSSW_12_6_CLANG_X_2022-08-31-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7729/27278/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53867e/27278/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53867e/27278/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test testCommonToolsUtil had ERRORS
---> test EgammaTowerIso_t had ERRORS

AddOn Tests

  • unknownAddOnTest might have timed out: FAILED - secs

Comparison Summary

Summary:

  • You potentially added 93443 lines to the logs
  • Reco comparison results: 16247 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3620448
  • DQMHistoTests: Total failures: 85691
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3534733
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 5 / 50 workflows

@aandvalenzuela aandvalenzuela changed the base branch from IB/CMSSW_12_6_X/master to IB/CMSSW_13_0_X/master November 24, 2022 14:09
@smuzaffar smuzaffar closed this Nov 26, 2022
@smuzaffar smuzaffar deleted the smuzaffar-patch-4 branch November 26, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants