Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS9] xrootd: enable readline and cleanup #7760

Merged
merged 1 commit into from Apr 6, 2022

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2022

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_4_X/cs9.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar smuzaffar merged commit 6320673 into IB/CMSSW_12_4_X/cs9 Apr 6, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2022

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-175797/23694/summary.html
COMMIT: 1f31bea
CMSSW: CMSSW_12_4_X_2022-04-01-2300/cs9_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7760/23694/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-175797/23694/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-175797/23694/git-merge-result

Unit Tests

I found errors in the following unit tests:


Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 68834 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3593033
  • DQMHistoTests: Total failures: 430533
  • DQMHistoTests: Total nulls: 281
  • DQMHistoTests: Total successes: 3162197
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.6400000000000001 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.975 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11834.0 ): 0.996 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 138.4 ): -0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 138.5 ): -0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 25202.0 ): -0.054 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 7.3 ): -0.269 KiB SiStrip/MechanicalView
  • Checked 200 log files, 45 edm output root files, 48 DQM output files

@smuzaffar smuzaffar deleted the cs9-xrootd-readline branch April 9, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants