Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[G4] Fix FTFP_BERT_EMM Physics list for Geant4 11.0 #7765

Conversation

aandvalenzuela
Copy link
Contributor

@aandvalenzuela aandvalenzuela commented Apr 7, 2022

this includes changes requested in cms-externals/geant4#58

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2022

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch IB/CMSSW_12_4_X/geant4.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@aandvalenzuela
Copy link
Contributor Author

please test

@aandvalenzuela aandvalenzuela changed the title [G4] Update commit hash to follow latest changes in externals [G4] Geant4 update latest changes in externals Apr 7, 2022
@smuzaffar smuzaffar changed the title [G4] Geant4 update latest changes in externals [G4] Fix FTFP_BERT_EMM Physics list for Geant4 11.0 Apr 7, 2022
@smuzaffar
Copy link
Contributor

+externals
external build and cmssw compilation look good. merging it for Geant4 special branch

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2022

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_4_X/geant4 IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d15dc/23719/summary.html
COMMIT: d39446b
CMSSW: CMSSW_12_4_GEANT4_X_2022-04-05-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7765/23719/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d15dc/23719/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d15dc/23719/git-merge-result

Comparison Summary

Summary:

  • You potentially added 6920 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 68535 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3593033
  • DQMHistoTests: Total failures: 431559
  • DQMHistoTests: Total nulls: 314
  • DQMHistoTests: Total successes: 3161138
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.8920000000000003 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.713 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11834.0 ): 2.606 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 136.874,... ): -0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 138.4 ): -0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 138.5 ): -0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 25202.0 ): -0.598 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 3.154 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): -1.537 KiB SiStrip/MechanicalView
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 18 / 47 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants