Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yaml-cpp to 0.7.0 #7788

Conversation

smuzaffar
Copy link
Contributor

Reverts #7787

need to test it for gcc11

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_4_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Apr 14, 2022

please test for cs8_amd64_gcc10

@smuzaffar
Copy link
Contributor Author

please test for cs8_amd64_gcc10

@smuzaffar
Copy link
Contributor Author

please test for cs9_amd64_gcc11

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-789a79/23902/summary.html
COMMIT: e6bab63
CMSSW: CMSSW_12_4_X_2022-04-12-2300/cs9_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7788/23902/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

make[2]: *** [test/prefix/googletest/CMakeFiles/gtest.dir/build.make:82: test/prefix/googletest/CMakeFiles/gtest.dir/src/gtest-all.cc.o] Error 1
make[2]: Leaving directory '/pool/condor/dir_256765/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/cs9_amd64_gcc11/external/yaml-cpp/0.7.0-49fbde0193b27de6becd287a01e9eb74/yaml-cpp-yaml-cpp-0.7.0'
make[1]: *** [CMakeFiles/Makefile2:1124: test/prefix/googletest/CMakeFiles/gtest.dir/all] Error 2
make[1]: Leaving directory '/pool/condor/dir_256765/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/cs9_amd64_gcc11/external/yaml-cpp/0.7.0-49fbde0193b27de6becd287a01e9eb74/yaml-cpp-yaml-cpp-0.7.0'
make: *** [Makefile:160: all] Error 2
error: Bad exit status from /pool/condor/dir_256765/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Okfjbl (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+yaml-cpp+0.7.0-49fbde0193b27de6becd287a01e9eb74
Bad exit status from /pool/condor/dir_256765/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Okfjbl (%build)


@smuzaffar
Copy link
Contributor Author

please test for cs9_amd64_gcc11

@cmsbuild
Copy link
Contributor

Pull request #7788 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

hold
may be it is not needed see #7790

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @smuzaffar
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Apr 14, 2022
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-789a79/23909/summary.html
COMMIT: 852be07
CMSSW: CMSSW_12_4_X_2022-04-13-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7788/23909/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-789a79/23909/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-789a79/23909/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3593039
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3593009
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

yaml-cpp is not required. So closing this PR

@smuzaffar smuzaffar closed this Apr 14, 2022
@smuzaffar smuzaffar deleted the revert-7787-revert-7780-update-yaml_cpp-0.6.2 branch April 14, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants