Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[G4] Fixed Geant4 compound materials construction #7793

Merged
merged 1 commit into from Apr 15, 2022

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_4_X/geant4_vecgeom.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar smuzaffar merged commit 58486f4 into IB/CMSSW_12_4_X/geant4_vecgeom Apr 15, 2022
@smuzaffar smuzaffar deleted the smuzaffar-patch-9 branch April 15, 2022 16:28
@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8153b/23942/summary.html
COMMIT: ac07d32
CMSSW: CMSSW_12_4_G4VECGEOM_X_2022-04-14-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7793/23942/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8153b/23942/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8153b/23942/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestDQMOnlineClient-l1tstage2_dqm_sourceclient had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 63580 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3593039
  • DQMHistoTests: Total failures: 426401
  • DQMHistoTests: Total nulls: 308
  • DQMHistoTests: Total successes: 3166308
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 218.35200000000003 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 10.848 KiB L1T/L1TStage2EMTF
  • DQMHistoSizes: changed ( 10224.0 ): -0.117 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11834.0 ): 1.312 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.006 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.246 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 7.3 ): 1.936 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): -1.493 KiB SiStrip/MechanicalView
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 14 / 47 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants