Drop TopRex #7808

iarspider · 2022-04-20T13:38:17Z

Notice: doesn't seem to be used in CMSSW. The only non-text references I could find are these: 1, 2. Not sure how to handle these.

cmsbuild · 2022-04-20T13:38:42Z

A new Pull Request was created by @iarspider for branch IB/CMSSW_12_4_X/devel.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

smuzaffar · 2022-04-24T04:33:04Z

please test

cmsbuild · 2022-04-24T07:24:51Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c83b18/24163/summary.html
COMMIT: 9e0283d
CMSSW: CMSSW_12_4_DEVEL_X_2022-04-22-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7808/24163/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c83b18/24163/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c83b18/24163/git-merge-result

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_DEVEL_X_2022-04-22-2300/src/GeneratorInterface/MCatNLOInterface/plugins/mcatnlo_hwursc.f
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_DEVEL_X_2022-04-22-2300/src/GeneratorInterface/MCatNLOInterface/plugins/mcatnlo_upevnt.f
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_DEVEL_X_2022-04-22-2300/src/GeneratorInterface/MCatNLOInterface/plugins/mcatnlo_upinit.f
>> Building  edm plugin tmp/slc7_amd64_gcc10/src/GeneratorInterface/MCatNLOInterface/plugins/GeneratorInterfaceMCatNLOSource/libGeneratorInterfaceMCatNLOSource.so
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lGeneratorInterfaceHerwig6Interface
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc10/src/GeneratorInterface/MCatNLOInterface/plugins/GeneratorInterfaceMCatNLOSource/libGeneratorInterfaceMCatNLOSource.so] Error 1
Leaving library rule at src/GeneratorInterface/MCatNLOInterface/plugins
Entering library rule at src/GeneratorInterface/MCatNLOInterface/test
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_DEVEL_X_2022-04-22-2300/src/GeneratorInterface/MCatNLOInterface/test/ZeeAnalyzer.cc
>> Building  edm plugin tmp/slc7_amd64_gcc10/src/GeneratorInterface/MCatNLOInterface/test/ZeeAnalyzer/libZeeAnalyzer.so

smuzaffar · 2022-04-25T06:41:41Z

please test

cmsbuild · 2022-04-25T11:41:33Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c83b18/24175/summary.html
COMMIT: 9e0283d
CMSSW: CMSSW_12_4_DEVEL_X_2022-04-24-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7808/24175/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c83b18/24175/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c83b18/24175/git-merge-result

Build

I found compilation error when building:

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: PhotosInterface.cc:(.text+0x29fe): undefined reference to `hepevt_'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc10/src/GeneratorInterface/PhotosInterface/plugins/PhotosInterfaceDefault/PhotosInterface.cc.o: in function `HepMC::HEPEVT_Wrapper::byte_num_to_double(unsigned int)':
PhotosInterface.cc:(.text._ZN5HepMC14HEPEVT_Wrapper18byte_num_to_doubleEj[_ZN5HepMC14HEPEVT_Wrapper18byte_num_to_doubleEj]+0x138): undefined reference to `hepevt_'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: PhotosInterface.cc:(.text._ZN5HepMC14HEPEVT_Wrapper18byte_num_to_doubleEj[_ZN5HepMC14HEPEVT_Wrapper18byte_num_to_doubleEj]+0x153): undefined reference to `hepevt_'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc10/src/GeneratorInterface/PhotosInterface/plugins/PhotosInterfaceDefault/PhotosInterface.cc.o:PhotosInterface.cc:(.text._ZN5HepMC14HEPEVT_Wrapper15byte_num_to_intEj[_ZN5HepMC14HEPEVT_Wrapper15byte_num_to_intEj]+0xa3): more undefined references to `hepevt_' follow
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc10/src/GeneratorInterface/PhotosInterface/plugins/PhotosInterfaceDefault/libPhotosInterfaceDefault.so] Error 1
Leaving library rule at src/GeneratorInterface/PhotosInterface/plugins
Entering library rule at src/GeneratorInterface/PhotosInterface/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_DEVEL_X_2022-04-24-2300/src/GeneratorInterface/PhotosInterface/plugins/PhotosppInterface.cc
>> Building  edm plugin tmp/slc7_amd64_gcc10/src/GeneratorInterface/PhotosInterface/plugins/PhotosppInterface/libPhotosppInterface.so

smuzaffar · 2022-04-25T11:44:25Z

@iarspider , do we need a cmssw pr to go with this change?

iarspider · 2022-04-25T12:54:07Z

@smuzaffar PhotosInterface was dropped in cms-sw/cmssw#37616, which was merged 18 hrs ago, could this PR be picking up old cmssw version?

EDIT: I could've missed some reference, let me double-check

EDIT2:

$ git clone https://github.com/cms-sw/cmssw.git -b CMSSW_12_4_DEVEL_X
$ find cmssw -name PhotosInterface.cc
# Nothing found

smuzaffar · 2022-04-25T13:02:26Z

@iarspider tests are run against CMSSW_12_4_DEVEL_X_2022-04-24-2300 which includes cms-sw/cmssw#37616

smuzaffar · 2022-04-25T13:12:04Z

test with out full_cmssw

smuzaffar · 2022-04-25T13:14:30Z

please test

smuzaffar · 2022-04-25T14:00:30Z

@smuzaffar PhotosInterface was dropped in cms-sw/cmssw#37616, which was merged 18 hrs ago, could this PR be picking up old cmssw version?

EDIT: I could've missed some reference, let me double-check

EDIT2:
$ git clone https://github.com/cms-sw/cmssw.git -b CMSSW_12_4_DEVEL_X
$ find cmssw -name PhotosInterface.cc
# Nothing found

ok issue understaood now. When PR tests are run for full_cmssw=true then bot was checking out CMSSW_12_4_X branch [a] instead of dedicated devel branch. cms-sw/cms-bot@b2d7595 should fix this issue. Anyway, I have restarted the tests without full_cmssw

[a]

11:15:13 ++ git branch
11:15:13 ++ grep '^  *CMSSW_'
11:15:13 + git checkout CMSSW_12_4_X
11:15:13 Switched to branch 'CMSSW_12_4_X'
11:15:13 Your branch is up to date with 'official-cmssw/CMSSW_12_4_X'.
11:15:13 + echo '/*/'
11:15:13 + git read-tree -mu HEAD

cmsbuild · 2022-04-26T01:42:40Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c83b18/24188/summary.html
COMMIT: 9e0283d
CMSSW: CMSSW_12_4_DEVEL_X_2022-04-24-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7808/24188/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c83b18/24188/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c83b18/24188/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/pool/condor/dir_211937/jenkins/workspace/compare-root-files-short-matrix/data/PR-c83b18/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 23063 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3695434
DQMHistoTests: Total failures: 43622
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3651789
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 205 log files, 45 edm output root files, 49 DQM output files
TriggerResults: found differences in 6 / 48 workflows

smuzaffar · 2022-04-26T07:16:35Z

please test

cmsbuild · 2022-04-26T12:04:36Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c83b18/24207/summary.html
COMMIT: 9e0283d
CMSSW: CMSSW_12_4_DEVEL_X_2022-04-25-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7808/24207/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/pool/condor/dir_117278/jenkins/workspace/compare-root-files-short-matrix/data/PR-c83b18/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 2995 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3695434
DQMHistoTests: Total failures: 6317
DQMHistoTests: Total nulls: 2
DQMHistoTests: Total successes: 3689093
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.113 KiB( 48 files compared)
DQMHistoSizes: changed ( 1000.0 ): -0.059 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 1000.0 ): -0.059 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 205 log files, 45 edm output root files, 49 DQM output files
TriggerResults: found differences in 1 / 48 workflows

smuzaffar · 2022-04-27T17:51:06Z

please test

No idea why we have too many comparison failures

cmsbuild · 2022-04-27T22:43:00Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c83b18/24275/summary.html
COMMIT: 9e0283d
CMSSW: CMSSW_12_4_DEVEL_X_2022-04-26-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7808/24275/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c83b18/24275/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c83b18/24275/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 14252 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3695434
DQMHistoTests: Total failures: 16086
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3679326
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 205 log files, 45 edm output root files, 49 DQM output files
TriggerResults: found differences in 1 / 48 workflows

smuzaffar · 2022-04-28T06:19:08Z

tests passed , lets get this in DEVEL IBs

Drop TopRex

9e0283d

cmsbuild added externals-pending orp-pending pending-signatures tests-pending labels Apr 20, 2022

cmsbuild added tests-started tests-rejected and removed tests-pending tests-started labels Apr 24, 2022

cmsbuild added tests-started tests-rejected and removed tests-rejected tests-started labels Apr 25, 2022

cmsbuild added tests-started and removed tests-rejected labels Apr 25, 2022

cmsbuild added tests-approved and removed tests-started labels Apr 26, 2022

cmsbuild added tests-started and removed tests-approved labels Apr 26, 2022

cmsbuild added tests-approved and removed tests-started labels Apr 26, 2022

cmsbuild added tests-started and removed tests-approved labels Apr 27, 2022

cmsbuild added tests-approved and removed tests-started labels Apr 27, 2022

smuzaffar merged commit f111831 into IB/CMSSW_12_4_X/devel Apr 28, 2022

smuzaffar deleted the drop-toprex branch May 2, 2022 19:33

iarspider mentioned this pull request May 5, 2022

[master] Drop legacy MC generators #7844

Merged

cmsbuild mentioned this pull request Nov 21, 2022

SCRAM V2 disto via latest cmssw releases #8187

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop TopRex #7808

Drop TopRex #7808

iarspider commented Apr 20, 2022

cmsbuild commented Apr 20, 2022

smuzaffar commented Apr 24, 2022

cmsbuild commented Apr 24, 2022

smuzaffar commented Apr 25, 2022

cmsbuild commented Apr 25, 2022

smuzaffar commented Apr 25, 2022

iarspider commented Apr 25, 2022 •

edited

smuzaffar commented Apr 25, 2022

smuzaffar commented Apr 25, 2022 •

edited

smuzaffar commented Apr 25, 2022

smuzaffar commented Apr 25, 2022

cmsbuild commented Apr 26, 2022

smuzaffar commented Apr 26, 2022

cmsbuild commented Apr 26, 2022

smuzaffar commented Apr 27, 2022

cmsbuild commented Apr 27, 2022

smuzaffar commented Apr 28, 2022

Drop TopRex #7808

Drop TopRex #7808

Conversation

iarspider commented Apr 20, 2022

cmsbuild commented Apr 20, 2022

smuzaffar commented Apr 24, 2022

cmsbuild commented Apr 24, 2022

Build

smuzaffar commented Apr 25, 2022

cmsbuild commented Apr 25, 2022

Build

smuzaffar commented Apr 25, 2022

iarspider commented Apr 25, 2022 • edited

smuzaffar commented Apr 25, 2022

smuzaffar commented Apr 25, 2022 • edited

smuzaffar commented Apr 25, 2022

smuzaffar commented Apr 25, 2022

cmsbuild commented Apr 26, 2022

Comparison Summary

smuzaffar commented Apr 26, 2022

cmsbuild commented Apr 26, 2022

Comparison Summary

smuzaffar commented Apr 27, 2022

cmsbuild commented Apr 27, 2022

Comparison Summary

smuzaffar commented Apr 28, 2022

iarspider commented Apr 25, 2022 •

edited

smuzaffar commented Apr 25, 2022 •

edited