Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alpaka to the devel branch as of 2022.05.03 / c493040fe0b #7842

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 3, 2022

Update alpaka to the HEAD of the devel branch as of 2022.05.03, corresponding to the commit c493040fe0b3ef9416bb0bbb8d45550c184a67e0 .

Relevant changes:

  • add braces around aggregate initializer.

Update alpaka to the HEAD of the devel branch as of 2022.05.03, corresponding to
the commit c493040fe0b3ef9416bb0bbb8d45550c184a67e0 .

Relevant changes:
  - add braces around aggregate initializer.
@fwyzard
Copy link
Contributor Author

fwyzard commented May 3, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2022

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_12_4_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented May 3, 2022

This should fix the error in cms-sw/cmssw#37716 and let us revert the workaround there.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 3, 2022

?

@fwyzard
Copy link
Contributor Author

fwyzard commented May 3, 2022

please test

@smuzaffar
Copy link
Contributor

@fwyzard , looks like there is network issue at CERN that is why requests are not reaching to jenkins ....

@makortel
Copy link
Contributor

makortel commented May 3, 2022

Could you add "alpaka" in the PR title? (easier to find it later if needed)

@fwyzard fwyzard changed the title Update the devel branch as of 2022.05.03 / c493040fe0b alpaka: update the devel branch as of 2022.05.03 / c493040fe0b May 3, 2022
@fwyzard fwyzard changed the title alpaka: update the devel branch as of 2022.05.03 / c493040fe0b update alpaka to the devel branch as of 2022.05.03 / c493040fe0b May 3, 2022
@fwyzard fwyzard changed the title update alpaka to the devel branch as of 2022.05.03 / c493040fe0b Update alpaka to the devel branch as of 2022.05.03 / c493040fe0b May 3, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2022

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1961c3/24416/summary.html
COMMIT: 6da07e6
CMSSW: CMSSW_12_4_X_2022-05-03-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7842/24416/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1961c3/24418/summary.html
COMMIT: 6da07e6
CMSSW: CMSSW_12_4_X_2022-05-03-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7842/24418/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1961c3/24418/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1961c3/24418/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 28 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3700548
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3700518
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1961c3/24439/summary.html
COMMIT: 6da07e6
CMSSW: CMSSW_12_4_X_2022-05-03-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7842/24439/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3700548
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3700518
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2022

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_4_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@fwyzard fwyzard deleted the IB/CMSSW_12_4_X/master_alpaka_2022.05.03 branch May 5, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants