Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define TBB_PREVIEW_TASK_GROUP_EXTENSIONS #7871

Merged
merged 1 commit into from May 16, 2022

Conversation

makortel
Copy link
Contributor

In order to use tbb::task_group::defer and tbb::task_handle.

Following #7674 (comment).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for branch IB/CMSSW_12_5_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@smuzaffar I just took a blind try based on your comment in #7674 (comment). Is this the right way to define that macro?

@Dr15Jones FYI

@Dr15Jones
Copy link

This
https://oneapi-src.github.io/oneTBB/main/reference/task_group_extensions.html

says we should set that macro to 1.

@smuzaffar
Copy link
Contributor

smuzaffar commented May 16, 2022

thanks @makortel , yes this is right place to set the flag. as @Dr15Jones suggested, please set it to 1 ( just add =1)

In order to use tbb::task_group::defer and tbb::task_handle
@cmsbuild
Copy link
Contributor

Pull request #7871 was updated.

@makortel
Copy link
Contributor Author

Thanks, done.

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-940f4a/24743/summary.html
COMMIT: 7c3acb3
CMSSW: CMSSW_12_5_X_2022-05-16-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7871/24743/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-940f4a/11634.301_TTbar_14TeV+2021_Run3FS+TTbar_14TeV_TuneCP5_GenSim+HARVESTNano

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3741432
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3741396
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_5_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@makortel makortel deleted the patch-1 branch May 16, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants