Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.4.X][igprof][el8] Handle ENDBR64 instruction #7906

Merged
merged 1 commit into from Jun 1, 2022

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Jun 1, 2022

backport of #7894
this fixes the igprof issues for el8. This has been integrated in 12.5.X

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2022

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_4_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2022

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_4_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f1c52/25146/summary.html
COMMIT: f63aa1a
CMSSW: CMSSW_12_4_X_2022-05-31-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7906/25146/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3668379
  • DQMHistoTests: Total failures: 1298
  • DQMHistoTests: Total nulls: 37
  • DQMHistoTests: Total successes: 3667022
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 833.5120000000001 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 132.827 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 11634.0,... ): 6.138 KiB HLT/Filters
  • DQMHistoSizes: changed ( 11634.0,... ): -0.047 KiB HLT/TAU
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 3 / 49 workflows

@smuzaffar
Copy link
Contributor Author

@qliphy @perrotta feel free to include this in 12.4.X

@perrotta
Copy link
Contributor

perrotta commented Jun 1, 2022

+1

@cmsbuild cmsbuild merged commit 9de6a92 into IB/CMSSW_12_4_X/master Jun 1, 2022
@smuzaffar smuzaffar deleted the smuzaffar-patch-5 branch June 1, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants