Update pacparser to 1.4.0 #7928

iarspider · 2022-06-13T09:50:34Z

No description provided.

iarspider · 2022-06-13T09:50:40Z

please test

cmsbuild · 2022-06-13T09:50:52Z

A new Pull Request was created by @iarspider for branch IB/CMSSW_12_5_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2022-06-13T14:16:31Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d22e0/25490/summary.html
COMMIT: 73c38a5
CMSSW: CMSSW_12_5_X_2022-06-13-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7928/25490/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

iarspider · 2022-06-13T14:23:01Z

please test

cmsbuild · 2022-06-13T14:23:07Z

Pull request #7928 was updated.

cmsbuild · 2022-06-13T15:19:57Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d22e0/25494/summary.html
COMMIT: 95ffdbe
CMSSW: CMSSW_12_5_X_2022-06-13-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7928/25494/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

* The action "build-external+frontier_client+2.9.1-6ab0bb2c49719a4268ad8b4668d996ec" was not completed successfully because Failed to build frontier_client. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc10/external/frontier_client/2.9.1-6ab0bb2c49719a4268ad8b4668d996ec/log. Final lines of the log file:
gcc -Wall  -DFRONTIER_DEBUG -fPIC -DPIC -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/expat/2.1.0-e2e74851cebffc0aa0988d120ae74fcd/include  -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/pacparser/1.4.0-7c82678fba70b88d74cdbf2802a5001b/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/zlib/1.2.11-71514f01d2850dfd0bcd391557259a58/include -I./include -I. -c frontier_error.c
gcc -DFNAPI_VERSION="\"2.9.1\"" -Wall  -DFRONTIER_DEBUG -fPIC -DPIC -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/expat/2.1.0-e2e74851cebffc0aa0988d120ae74fcd/include  -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/pacparser/1.4.0-7c82678fba70b88d74cdbf2802a5001b/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/zlib/1.2.11-71514f01d2850dfd0bcd391557259a58/include -I./include -I. -c frontier_config.c
gcc -Wall  -DFRONTIER_DEBUG -fPIC -DPIC -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/expat/2.1.0-e2e74851cebffc0aa0988d120ae74fcd/include  -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/pacparser/1.4.0-7c82678fba70b88d74cdbf2802a5001b/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/zlib/1.2.11-71514f01d2850dfd0bcd391557259a58/include -I./include -I. -c fn-mem.c
gcc -Wall  -DFRONTIER_DEBUG -fPIC -DPIC -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/expat/2.1.0-e2e74851cebffc0aa0988d120ae74fcd/include  -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/pacparser/1.4.0-7c82678fba70b88d74cdbf2802a5001b/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/zlib/1.2.11-71514f01d2850dfd0bcd391557259a58/include -I./include -I. -c pacparser-dlopen.c
pacparser-dlopen.c:94:6: error: conflicting types for 'pacparser_setmyip'
94 | void pacparser_setmyip(const char *ip)
|      ^~~~~~~~~~~~~~~~~
In file included from pacparser-dlopen.c:17:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/pacparser/1.4.0-7c82678fba70b88d74cdbf2802a5001b/include/pacparser.h:111:5: note: previous declaration of 'pacparser_setmyip' was here
111 | int pacparser_setmyip(const char *ip                 // Custom IP address.

iarspider · 2022-06-13T15:41:57Z

@smuzaffar this is a known issue, let me prepare a patch real quick...

cmsbuild · 2022-06-13T15:48:31Z

Pull request #7928 was updated.

iarspider · 2022-06-13T15:48:32Z

please test

cmsbuild · 2022-06-13T16:11:16Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d22e0/25495/summary.html
COMMIT: 69e8df6
CMSSW: CMSSW_12_5_X_2022-06-13-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7928/25495/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

iarspider · 2022-06-13T16:12:59Z

please test

cmsbuild · 2022-06-13T16:13:13Z

Pull request #7928 was updated.

smuzaffar · 2022-06-13T16:16:25Z

@iarspider , there is no need to create temp branch. You can just create a PR for https://github.com/cms-externals/frontier_client and test that pr along with this. e.g. you can run tests like please test with cms-externals/frontier_client#XXXX and bot should test both PRs together :-)

iarspider · 2022-06-13T16:30:05Z

Ah, didn't think of that solution. But I will need to change commit id anyway once frontier_client PR is merged.

cmsbuild · 2022-06-13T21:13:28Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d22e0/25496/summary.html
COMMIT: 59b96d4
CMSSW: CMSSW_12_5_X_2022-06-13-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7928/25496/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3659074
DQMHistoTests: Total failures: 14
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3659038
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: no differences found

smuzaffar · 2022-06-14T15:52:08Z

please test with cms-externals/frontier_client#3

cmsbuild · 2022-06-14T20:38:31Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d22e0/25521/summary.html
COMMIT: 59b96d4
CMSSW: CMSSW_12_5_X_2022-06-14-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7928/25521/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3659074
DQMHistoTests: Total failures: 13
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3659038
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: no differences found

cmsbuild · 2022-06-15T18:37:42Z

Pull request #7928 was updated.

Update pacparser to 1.4.0

73c38a5

cmsbuild added externals-pending orp-pending pending-signatures tests-started labels Jun 13, 2022

cmsbuild added tests-rejected and removed tests-started labels Jun 13, 2022

iarspider added 2 commits June 13, 2022 16:22

Update pacparser.spec

7b59b45

Update pacparser.spec

95ffdbe

cmsbuild added tests-started and removed tests-rejected labels Jun 13, 2022

cmsbuild added tests-rejected and removed tests-started labels Jun 13, 2022

Update froniter_client as well

69e8df6

cmsbuild added tests-pending and removed tests-rejected labels Jun 13, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 13, 2022

cmsbuild added tests-rejected and removed tests-started labels Jun 13, 2022

Temporary change branch

59b96d4

cmsbuild added tests-started and removed tests-rejected labels Jun 13, 2022

cmsbuild added tests-approved and removed tests-started labels Jun 13, 2022

cmsbuild added requires-external tests-started and removed tests-approved labels Jun 14, 2022

cmsbuild added tests-approved and removed tests-started labels Jun 14, 2022

Update frontier_client.spec

6714703

cmsbuild added tests-pending and removed tests-approved requires-external labels Jun 15, 2022

smuzaffar merged commit a2e317d into IB/CMSSW_12_5_X/master Jun 15, 2022

smuzaffar deleted the update/pacparser-1.4.0 branch June 15, 2022 18:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update pacparser to 1.4.0 #7928

Update pacparser to 1.4.0 #7928

iarspider commented Jun 13, 2022

iarspider commented Jun 13, 2022

cmsbuild commented Jun 13, 2022

cmsbuild commented Jun 13, 2022

iarspider commented Jun 13, 2022

cmsbuild commented Jun 13, 2022

cmsbuild commented Jun 13, 2022

iarspider commented Jun 13, 2022

cmsbuild commented Jun 13, 2022

iarspider commented Jun 13, 2022

cmsbuild commented Jun 13, 2022

iarspider commented Jun 13, 2022

cmsbuild commented Jun 13, 2022

smuzaffar commented Jun 13, 2022 •

edited

iarspider commented Jun 13, 2022

cmsbuild commented Jun 13, 2022

smuzaffar commented Jun 14, 2022

cmsbuild commented Jun 14, 2022

cmsbuild commented Jun 15, 2022

Update pacparser to 1.4.0 #7928

Update pacparser to 1.4.0 #7928

Conversation

iarspider commented Jun 13, 2022

iarspider commented Jun 13, 2022

cmsbuild commented Jun 13, 2022

cmsbuild commented Jun 13, 2022

External Build

iarspider commented Jun 13, 2022

cmsbuild commented Jun 13, 2022

cmsbuild commented Jun 13, 2022

External Build

iarspider commented Jun 13, 2022

cmsbuild commented Jun 13, 2022

iarspider commented Jun 13, 2022

cmsbuild commented Jun 13, 2022

External Build

iarspider commented Jun 13, 2022

cmsbuild commented Jun 13, 2022

smuzaffar commented Jun 13, 2022 • edited

iarspider commented Jun 13, 2022

cmsbuild commented Jun 13, 2022

Comparison Summary

smuzaffar commented Jun 14, 2022

cmsbuild commented Jun 14, 2022

Comparison Summary

cmsbuild commented Jun 15, 2022

smuzaffar commented Jun 13, 2022 •

edited