Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable aggressive compiler optimizations for VecGeom #7987

Merged
merged 1 commit into from Jul 11, 2022
Merged

Conversation

hahnjo
Copy link
Contributor

@hahnjo hahnjo commented Jul 9, 2022

It seems that gcc10 miscompiles (some of) the VecGeom code at -O3. In my tests, switching back to -O2 fixes the crashes. More details and discussion if that is indeed a compiler problem or an issue in the code in https://sft.its.cern.ch/jira/projects/VECGEOM/issues/VECGEOM-600

It seems that gcc10 miscompiles (some of) the VecGeom code at -O3. In
my tests, switching back to -O2 fixes the crashes. More details and
discussion if that is indeed a compiler problem or an issue in the code
in https://sft.its.cern.ch/jira/projects/VECGEOM/issues/VECGEOM-600
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2022

A new Pull Request was created by @hahnjo (Jonas Hahnfeld) for branch IB/CMSSW_12_5_X/geant4_vecgeom.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@iarspider
Copy link
Contributor

iarspider commented Jul 9, 2022 via email

@hahnjo
Copy link
Contributor Author

hahnjo commented Jul 11, 2022

A quick update on some further investigations: The crashes are exposed by a change that landed for VecGeom 1.1.19, but the miscompilation can also be reproduced with earlier versions when using gcc10. So this change is probably also a candidate for application to production releases...

@iarspider
Copy link
Contributor

please test for CMSSW_12_5_G4VECGEOM_X/el8_amd64_gcc10

@smuzaffar
Copy link
Contributor

thanks @hahnjo , #7992 include this change for productions releases

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9357ea/26119/summary.html
COMMIT: 08a6186
CMSSW: CMSSW_12_5_G4VECGEOM_X_2022-07-07-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7987/26119/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9357ea/26119/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9357ea/26119/git-merge-result

RelVals

  • 23234.023234.0_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step1_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log
  • 28234.028234.0_TTbar_14TeV+2026D60+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step1_TTbar_14TeV+2026D60+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log
  • 35034.035034.0_TTbar_14TeV+2026D77+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step1_TTbar_14TeV+2026D77+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log

@smuzaffar smuzaffar merged commit 1fef219 into cms-sw:IB/CMSSW_12_5_X/geant4_vecgeom Jul 11, 2022
@hahnjo hahnjo deleted the vecgeom-O2 branch July 11, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants