New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable aggressive compiler optimizations for VecGeom #7987
Disable aggressive compiler optimizations for VecGeom #7987
Conversation
It seems that gcc10 miscompiles (some of) the VecGeom code at -O3. In my tests, switching back to -O2 fixes the crashes. More details and discussion if that is indeed a compiler problem or an issue in the code in https://sft.its.cern.ch/jira/projects/VECGEOM/issues/VECGEOM-600
A new Pull Request was created by @hahnjo (Jonas Hahnfeld) for branch IB/CMSSW_12_5_X/geant4_vecgeom. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
please test
…On Sat, Jul 9, 2022, 13:44 cmsbuild ***@***.***> wrote:
A new Pull Request was created by @hahnjo <https://github.com/hahnjo>
(Jonas Hahnfeld) for branch IB/CMSSW_12_5_X/geant4_vecgeom.
@cmsbuild <https://github.com/cmsbuild>, @smuzaffar
<https://github.com/smuzaffar>, @aandvalenzuela
<https://github.com/aandvalenzuela>, @iarspider
<https://github.com/iarspider> can you please review it and eventually
sign? Thanks.
@perrotta <https://github.com/perrotta>, @dpiparo
<https://github.com/dpiparo>, @qliphy <https://github.com/qliphy>,
@rappoccio <https://github.com/rappoccio> you are the release manager for
this.
cms-bot commands are listed here
<http://cms-sw.github.io/cms-bot-cmssw-cmds.html>
—
Reply to this email directly, view it on GitHub
<#7987 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE3NOVLPE7KU7OQWO2I5TLVTFQ2TANCNFSM53DIJAWA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
A quick update on some further investigations: The crashes are exposed by a change that landed for VecGeom 1.1.19, but the miscompilation can also be reproduced with earlier versions when using gcc10. So this change is probably also a candidate for application to production releases... |
please test for CMSSW_12_5_G4VECGEOM_X/el8_amd64_gcc10 |
-1 Failed Tests: RelVals The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: RelVals
|
It seems that gcc10 miscompiles (some of) the VecGeom code at
-O3
. In my tests, switching back to-O2
fixes the crashes. More details and discussion if that is indeed a compiler problem or an issue in the code in https://sft.its.cern.ch/jira/projects/VECGEOM/issues/VECGEOM-600