Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pythia8][306] Pythia Update to fix tau decays #8139

Merged
merged 3 commits into from Oct 26, 2022

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Oct 24, 2022

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_6_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34f825/28474/summary.html
COMMIT: d1a9ceb
CMSSW: CMSSW_12_6_X_2022-10-24-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8139/28474/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@smuzaffar
Copy link
Contributor Author

please test with cms-externals/pythia8#29

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34f825/28477/summary.html
COMMIT: d1a9ceb
CMSSW: CMSSW_12_6_X_2022-10-24-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8139/28477/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Requested to quit.
Requested to quit.
* The action "build-external+pythia8+306-ce7ac3b73ba2c31da89d239e7552db72" was not completed successfully because Failed to build pythia8. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc10/external/pythia8/306-ce7ac3b73ba2c31da89d239e7552db72/log. Final lines of the log file:
|   couplingsPtrIn
src/HelicityMatrixElements.cc: In member function 'virtual void Pythia8::HMETwoFermions2GammaZ2TwoFermions::initConstants()':
src/HelicityMatrixElements.cc:408:11: error: 'couplingsPtr' was not declared in this scope; did you mean 'Couplings'?
408 |   sin2W = couplingsPtr->sin2thetaW();
|           ^~~~~~~~~~~~
|           Couplings
src/HelicityMatrixElements.cc: In member function 'virtual void Pythia8::HMEZ2TwoFermions::initConstants()':
src/HelicityMatrixElements.cc:681:10: error: 'couplingsPtr' was not declared in this scope; did you mean 'Couplings'?


@cmsbuild
Copy link
Contributor

Pull request #8139 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #8139 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34f825/28487/summary.html
COMMIT: 8f2876c
CMSSW: CMSSW_12_6_X_2022-10-24-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8139/28487/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3378384
  • DQMHistoTests: Total failures: 15
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3378347
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 201 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aandvalenzuela
Copy link
Contributor

From the discussion in Software Release meeting, this PR can be merged as soon as possible. The next step is to discuss with @cms-sw/generators-l2 and PPD if a backport to 12_4_X is needed. Thanks!

@smuzaffar smuzaffar changed the title [Pythia8][306] Get patched sources from cms-externals [Pythia8][306] Pythia Update to fix tau decays Oct 26, 2022
@smuzaffar
Copy link
Contributor Author

+externals

@cms-sw/generators-l2 , @perrotta @rappoccio this PR includes the pythia8 fix for tau decays ( cms-externals/pythia8#29 ) . Feel free to include it for next 12.6.X IB/pre-release. Let us know if this should be backported to 12.4/12.5 release cycles

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_6_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@agrohsje
Copy link

Indeed, a back-port to 12_4 is needed as this will be used in the Run3 MC campaign we are starting now. Thanks so much!

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants