Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tag for L1Trigger-L1TMuon to V01-07-00 - [CMSSW_12_4_X] #8143

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Oct 26, 2022

Move L1Trigger-L1TMuon data to new tag in 12_4_X, see
cms-data/L1Trigger-L1TMuon#23

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 26, 2022

A new Pull Request was created by @perrotta (Andrea Perrotta) for branch IB/CMSSW_12_4_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@@ -3,10 +3,10 @@
#Once a non-default section is empty then cleanup that section and remove its cmsdist/${PACKAGE_TYPE}.file
#If there is no customization for the packae then remove its .spec and .file
[default]
L1Trigger-L1TMuon=V01-06-00
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perrotta , shouldn't this be V01-07-00?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perrotta , shouldn't this be V01-07-00?

Indeed, thank you @smuzaffar

@smuzaffar
Copy link
Contributor

backport of #8137

@cmsbuild
Copy link
Contributor

Pull request #8143 was updated.

@smuzaffar
Copy link
Contributor

+externals
its a backport of #8137 and only contain new data files, so can be safely merged in 12.4.X

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_4_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47a0b4/28532/summary.html
COMMIT: 2e597ac
CMSSW: CMSSW_12_4_X_2022-10-26-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8143/28532/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3675164
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3675128
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor Author

+1

  • Needed by #39845
  • It only includes new data

@cmsbuild cmsbuild merged commit 36f27d7 into IB/CMSSW_12_4_X/master Oct 27, 2022
@smuzaffar smuzaffar deleted the Update-tag-for-L1Trigger-L1TMuon-to-V01-07-00-1 branch November 8, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants