Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated root to tip of branch v6-26-00-patches #8157

Closed
wants to merge 2 commits into from
Closed

Updated root to tip of branch v6-26-00-patches #8157

wants to merge 2 commits into from

Conversation

iarspider
Copy link
Contributor

No description provided.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_12_6_X/rootnext.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1a74a/28667/summary.html
COMMIT: 0e22676
CMSSW: CMSSW_12_6_ROOT626_X_2022-10-30-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8157/28667/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Checking EDM Class Transients in libTrackingToolsPatternTools.so
Suggestion: You can run 'scram build updateclassversion' to generate src/L1Trigger/L1THGCalUtilities/src/classes_def.xml.generated with updated ClassVersion
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libL1TriggerL1TGlobal.so
@@@@ ----> OK  EDM Class Version 
gmake: *** [tmp/el8_amd64_gcc10/edm_checks/libL1TriggerL1THGCalUtilities.so] Error 1
>> Checking EDM Class Transients in libTrackingToolsTrajectoryState.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libTrackingToolsTransientTrackingRecHit.so
>> Checking EDM Class Version for src/AnalysisDataFormats/SUSYBSMObjects/src/classes_def.xml in libAnalysisDataFormatsSUSYBSMObjects.so
TFile::Init:0: RuntimeWarning: no StreamerInfo found in /cvmfs/cms-ib.cern.ch/nweek-02757/el8_amd64_gcc10/cms/cmssw/CMSSW_12_6_ROOT626_X_2022-10-30-2300/lib/el8_amd64_gcc10/SimDataFormatsEncodedEventId_xr_rdict.pcm therefore preventing schema evolution when reading this file. The file was produced with version 6.26/07 of ROOT.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #8157 was updated.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1a74a/28684/summary.html
COMMIT: 6762eab
CMSSW: CMSSW_12_6_ROOT626_X_2022-10-30-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8157/28684/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libAlignmentLaserAlignment.so
Suggestion: You can run 'scram build updateclassversion' to generate src/CondFormats/HcalObjects/src/classes_def.xml.generated with updated ClassVersion
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libAlignmentOfflineValidation.so
gmake: *** [tmp/el8_amd64_gcc10/edm_checks/libCondFormatsHcalObjects.so] Error 1
>> Checking EDM Class Version for src/CondFormats/ESObjects/src/classes_def.xml in libCondFormatsESObjects.so
@@@@ ----> OK  EDM Class Transients 
@@@@ ----> OK  EDM Class Transients 
@@@@ ----> OK  EDM Class Transients 
@@@@ ----> OK  EDM Class Transients

@smuzaffar
Copy link
Contributor

smuzaffar commented Nov 1, 2022 •
edited

test parameters:

  • full_cmssw = true

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2022

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1a74a/28697/summary.html
COMMIT: 6762eab
CMSSW: CMSSW_12_6_ROOT626_X_2022-10-31-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8157/28697/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/week1/el8_amd64_gcc10/cms/cmssw/CMSSW_12_6_ROOT626_X_2022-10-31-2300/src/FWCore/Utilities/scripts/edmCheckClassVersion", line 181, in 
    raise RuntimeError("failed to load library '"+options.library+"'")
RuntimeError: failed to load library 'libAnalysisDataFormatsTrackInfo.so'
Suggestion: You can run 'scram build updateclassversion' to generate src/AnalysisDataFormats/TrackInfo/src/classes_def.xml.generated with updated ClassVersion
gmake: *** [tmp/el8_amd64_gcc10/edm_checks/libAnalysisDataFormatsTrackInfo.so] Error 1
>> Checking EDM Class Version for src/CUDADataFormats/PortableTestObjects/src/classes_def.xml in libCUDADataFormatsPortableTestObjects.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libAnalysisDataFormatsSUSYBSMObjects.so
@@@@ ----> OK  EDM Class Version 
@@@@ ----> OK  EDM Class Version

@smuzaffar
Copy link
Contributor

please test
fixed test parameters typo and restart the tests with full cmssw

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2022

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1a74a/28701/summary.html
COMMIT: 6762eab
CMSSW: CMSSW_12_6_ROOT626_X_2022-10-31-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8157/28701/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1a74a/28701/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1a74a/28701/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16491 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3416398
  • DQMHistoTests: Total failures: 42793
  • DQMHistoTests: Total nulls: 4
  • DQMHistoTests: Total successes: 3373579
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.547 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): 1.547 KiB SiStrip/MechanicalView
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 5 / 46 workflows

@smuzaffar
Copy link
Contributor

usual results, closing it as we hold the root 6.26 update till ROOT626 validation

@smuzaffar smuzaffar closed this Nov 1, 2022
@iarspider iarspider deleted the root-update-v6-26-00-patches-20221031 branch February 12, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures tests-rejected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iarspider @cmsbuild @smuzaffar