Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT626] Root update v6 26 00 patches 20221220 #8239

Conversation

aandvalenzuela
Copy link
Contributor

No description provided.

@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch IB/CMSSW_13_0_X/rootnext.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-62a442/29713/summary.html
COMMIT: 20af6b4
CMSSW: CMSSW_13_0_ROOT626_X_2022-12-19-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8239/29713/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libPhysicsToolsMVAComputer.so
@@@@ ----> OK  EDM Class Version 
Suggestion: You can run 'scram build updateclassversion' to generate src/L1Trigger/L1THGCalUtilities/src/classes_def.xml.generated with updated ClassVersion
>> Checking EDM Class Transients in libPhysicsToolsSelectorUtils.so
gmake: *** [tmp/el8_amd64_gcc11/edm_checks/libL1TriggerL1THGCalUtilities.so] Error 1
Error in : version mismatch, /pool/condor/dir_277390/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_ROOT626_X_2022-12-19-2300/lib/el8_amd64_gcc11/libPhysicsToolsPatUtils.so = 62607, ROOT = 62611
Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_ROOT626_X_2022-12-19-2300/src/FWCore/Utilities/scripts/edmCheckClassVersion", line 181, in 
    raise RuntimeError("failed to load library '"+options.library+"'")
RuntimeError: failed to load library 'libPhysicsToolsPatUtils.so'


@cmsbuild
Copy link
Contributor

Pull request #8239 was updated.

@aandvalenzuela
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-62a442/29721/summary.html
COMMIT: 97b44d8
CMSSW: CMSSW_13_0_ROOT626_X_2022-12-19-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8239/29721/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-62a442/29721/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-62a442/29721/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 16415 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555748
  • DQMHistoTests: Total failures: 38882
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3516844
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.258 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): 0.258 KiB SiStrip/MechanicalView
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 6 / 47 workflows

@aandvalenzuela
Copy link
Contributor Author

TestIOPoolInputNoParentDictionary is a known failure due to version update.

@aandvalenzuela
Copy link
Contributor Author

Waiting for root6.26 validation, closing it for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants