Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BuildRules] Disable LTO flags for ROCM products #8291

Merged
merged 1 commit into from Feb 7, 2023

Conversation

smuzaffar
Copy link
Contributor

I think problem is mixing LTO objects build with llvm (hipcc) and gcc. For now lets disable LTO for rocm products. I will check if for rocm products ( where .hip.cc files exists) we can compile default .cc files with llvm instead of gcc

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2023

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_0_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

test parameters:

  • addpkg = HeterogeneousCore

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

FYI @fwyzard @makortel

@fwyzard
Copy link
Contributor

fwyzard commented Feb 6, 2023

I will check if for rocm products ( where .hip.cc files exists) we can compile default .cc files with llvm instead of gcc

Most likely we can - but I'm not sure if we should.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38b7c6/30416/summary.html
COMMIT: 915ccea
CMSSW: CMSSW_13_0_X_2023-02-05-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8291/30416/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555495
  • DQMHistoTests: Total failures: 423
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555050
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_13_0_LTO_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38b7c6/30432/summary.html
COMMIT: 915ccea
CMSSW: CMSSW_13_0_LTO_X_2023-02-06-1100/el8_aarch64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8291/30432/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38b7c6/30432/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38b7c6/30432/git-merge-result

@smuzaffar
Copy link
Contributor Author

+externals
this shoudl fix the LTO build errors for rocm binaries

@smuzaffar smuzaffar merged commit 2d5e6ab into IB/CMSSW_13_0_X/master Feb 7, 2023
@smuzaffar smuzaffar deleted the smuzaffar-patch-17 branch February 7, 2023 08:27
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2023

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants