Update to ROCm 5.4.3

[fwyzard]

In ROCm v5.4.3, improvements to the compiler address errors with the following signatures:

• error: unhandled SGPR spill to memory
• cannot scavenge register without an emergency spill slot!
• error: ran out of registers during register allocation

See https://docs.amd.com/bundle/ROCm-Release-Notes-v5.4.3 for the full release notes.

[fwyzard]

please test

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_13_0_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

[smuzaffar]

@fwyzard , looks like 5.4.3 version is not yet available under /cvmfs/patatrack.cern.ch/externals/x86_64/rhel8/amd

[cmsbuild]

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-107bdb/30483/summary.html
COMMIT: 74966db
CMSSW: CMSSW_13_0_X_2023-02-07-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8299/30483/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

+ OSDIR=/cvmfs/patatrack.cern.ch/externals/x86_64/rhel8
+ '[' -d /cvmfs/patatrack.cern.ch/externals/x86_64/rhel8 ']'
+ BASEDIR=/cvmfs/patatrack.cern.ch/externals/x86_64/rhel8/amd/rocm-5.4.3
+ mkdir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/a9679ab6ba5d3585d722a608238f3443/opt/cmssw/el8_amd64_gcc11/external/rocm/5.4.3-a9679ab6ba5d3585d722a608238f3443/bin
+ test -d /cvmfs/patatrack.cern.ch/externals/x86_64/rhel8/amd/rocm-5.4.3/bin
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.QfJ0JC (%install)


RPM build errors:
line 35: It's not recommended to have unversioned Obsoletes: Obsoletes: external+rocm+5.4.3-a9679ab6ba5d3585d722a608238f3443
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.QfJ0JC (%install)


[fwyzard]

Mhm, guess I was to quick to run the tests, let's wait for the CVMFS update to propagate.

[fwyzard]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-107bdb/30488/summary.html
COMMIT: 74966db
CMSSW: CMSSW_13_0_X_2023-02-07-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8299/30488/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 16 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555852
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555827
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[smuzaffar]

looks good

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)