Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CICADA and hls4mlEmulatorExtras specs #8307

Merged
merged 8 commits into from Feb 14, 2023

Conversation

smuzaffar
Copy link
Contributor

Follow up on cms-sw/cmssw#40277
This adds two new packages

  • hls4mlEmulatorExtras
  • CICADA Model with two versions

Currently it is using my forks of these projects but once cms-hls4ml/hls4mlEmulatorExtras#1
cms-hls4ml/CICADA#1 are merged and we have proper tags for these then I will update the PR. For now this is only for testing to see the built

@smuzaffar smuzaffar changed the title added CICADA and hls4mlEmulatorExtras specs [Do not merge] added CICADA and hls4mlEmulatorExtras specs Feb 10, 2023
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_0_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #8307 was updated.

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5ba7de/30573/summary.html
COMMIT: db1fddc
CMSSW: CMSSW_13_0_X_2023-02-09-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8307/30573/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@cmsbuild
Copy link
Contributor

Pull request #8307 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5ba7de/30575/summary.html
COMMIT: 98405d7
CMSSW: CMSSW_13_0_X_2023-02-09-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8307/30575/install.sh to create a dev area with all the needed externals and cmssw changes.

@smuzaffar smuzaffar changed the title [Do not merge] added CICADA and hls4mlEmulatorExtras specs Added CICADA and hls4mlEmulatorExtras specs Feb 14, 2023
@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #8307 was updated.

@cms-sw cms-sw deleted a comment from cmsbuild Feb 14, 2023
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5ba7de/30623/summary.html
COMMIT: 97a3ef3
CMSSW: CMSSW_13_1_X_2023-02-14-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8307/30623/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 10 lines to the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555852
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555822
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 7386.2999999999965 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 369.315 KiB L1T/L1TStage2CaloLayer1
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

please test for el8_aarch64_gcc11

@smuzaffar
Copy link
Contributor Author

please test for el8_ppc64le_gcc11

@cmsbuild
Copy link
Contributor

Pull request #8307 was updated.

@smuzaffar
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_1_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants