Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Alpaka to the development branch as of 2023.02.15 [13.0.x] #8316

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Feb 15, 2023

Update the version of alpaka to the HEAD of the develop branch as of 2023.02.15, corresponding to the commit alpaka-group/alpaka@b849ce43dbf .

Major changes:

  • replace BOOST_LANG_HIP with HIP_VERSION: the former is available only when compiling HIP code with hipcc or clang, while the latter is available also while using the HIP host API with other compilers.

Other changes:

  • fix HIP/ROCm compilation warnings;
  • make ALPAKA_FN_INLINE always inline;
  • remove old clang-cuda workarounds.

Update the version of alpaka to the HEAD of the develop branch as of 2023.02.15,
corresponding to the commit b849ce43dbf .

Major changes:
  - replace BOOST_LANG_HIP with HIP_VERSION: the former is available only when
    compiling HIP code with hipcc or clang, while the latter is available also
    while using the HIP host API with other compilers.

Other changes:
  - fix HIP/ROCm compilation warnings;
  - make ALPAKA_FN_INLINE always inline;
  - remove old clang-cuda workarounds.
@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 15, 2023

backport #8315

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 15, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 15, 2023

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_13_0_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ccbb2/30639/summary.html
COMMIT: 3381546
CMSSW: CMSSW_13_0_X_2023-02-14-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8316/30639/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 10 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555852
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555822
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 7386.2999999999965 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 369.315 KiB L1T/L1TStage2CaloLayer1
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals
@perrotta @rappoccio fel free to merge it for 13.0.X ( this is a backport )

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 2, 2023

@perrotta @rappoccio this is in master since a while... can we merge it for 13.0.0 ?

@perrotta
Copy link
Contributor

perrotta commented Mar 2, 2023

+1

@cmsbuild cmsbuild merged commit 0fac25f into cms-sw:IB/CMSSW_13_0_X/master Mar 2, 2023
@fwyzard fwyzard deleted the IB/CMSSW_13_0_X/master_Alpaka_from_master branch March 3, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants