Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CepGen 1.1.0, CMake 3.25.2 #8319

Merged
merged 2 commits into from Feb 18, 2023
Merged

Conversation

forthommel
Copy link
Contributor

@forthommel forthommel commented Feb 16, 2023

This PR bumps the version of CepGen to 1.1.0. Changelog in https://cepgen.hepforge.org/changelog.html.

As a collateral damage, the CMake version is bumped to 3.25.2.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @forthommel (Laurent Forthomme) for branch IB/CMSSW_13_1_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8f70c/30691/summary.html
COMMIT: 79c36f6
CMSSW: CMSSW_13_1_X_2023-02-16-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8319/30691/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

CepGen/CMakeLists.txt:59 (cepgen_build)


-- Configuring incomplete, errors occurred!
See also "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/cepgen/1.1.0-3c31a6d614c3352916bab9ae635a3fae/build/CMakeFiles/CMakeOutput.log".
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.JSlb6a (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+cepgen+1.1.0-3c31a6d614c3352916bab9ae635a3fae
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.JSlb6a (%build)


@forthommel
Copy link
Contributor Author

Hi @smuzaffar,
I see that cmake_path was only introduced in CMake v>=3.20, while the default one used appears to be 3.18. Is there a way to bump the version? Or should I issue a patch removing the usage of this command?

@smuzaffar
Copy link
Contributor

@forthommel , I would suggest to bump cmake version to 3.25.2 in your branch ( the version we have in cmsdist is 2 years old)

Bumped CMake version to 3.25.2
@forthommel
Copy link
Contributor Author

Thanks for the quick reply, @smuzaffar! Just pushed!

@cmsbuild
Copy link
Contributor

Pull request #8319 was updated.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8f70c/30710/summary.html
COMMIT: a304015
CMSSW: CMSSW_13_1_X_2023-02-17-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8319/30710/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 37 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529029
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3529007
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar changed the title CepGen 1.1.0 CepGen 1.1.0, CMake 3.25.2 Feb 18, 2023
@smuzaffar smuzaffar merged commit 342481f into cms-sw:IB/CMSSW_13_1_X/master Feb 18, 2023
@forthommel
Copy link
Contributor Author

Many thanks for the very fast and fruitful interaction, @smuzaffar !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants