Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update AXOL1TL to 1.0.0 #8384

Merged
merged 1 commit into from Mar 16, 2023

Conversation

jmduarte
Copy link
Member

@jmduarte jmduarte commented Mar 15, 2023

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jmduarte (Javier Duarte) for branch IB/CMSSW_13_1_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@jmduarte jmduarte changed the title update AXOL1TL to 0.3.0 update AXOL1TL to 0.4.0 Mar 15, 2023
@jmduarte jmduarte marked this pull request as ready for review March 15, 2023 20:43
@cmsbuild
Copy link
Contributor

Pull request #8384 was updated.

@jmduarte jmduarte marked this pull request as draft March 16, 2023 01:00
@jmduarte jmduarte changed the title update AXOL1TL to 0.4.0 update AXOL1TL to 0.5.0 Mar 16, 2023
@cmsbuild
Copy link
Contributor

Pull request #8384 was updated.

@jmduarte jmduarte changed the title update AXOL1TL to 0.5.0 update AXOL1TL to 1.0.0 Mar 16, 2023
@cmsbuild
Copy link
Contributor

Pull request #8384 was updated.

@jmduarte jmduarte marked this pull request as ready for review March 16, 2023 13:51
@cmsbuild
Copy link
Contributor

Pull request #8384 was updated.

@jmduarte
Copy link
Member Author

@smuzaffar this is now ready to be tested, thank you!

@iarspider
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cb539d/31320/summary.html
COMMIT: 902c59d
CMSSW: CMSSW_13_1_X_2023-03-16-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8384/31320/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 15 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3550819
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3550792
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit a37be15 into cms-sw:IB/CMSSW_13_1_X/master Mar 16, 2023
9 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants