Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update onnxruntime to 1.14.1 #8397

Merged
merged 3 commits into from Apr 10, 2023
Merged

Conversation

iarspider
Copy link
Contributor

No description provided.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_13_1_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33a70b/31445/summary.html
COMMIT: 8f5b9b5
CMSSW: CMSSW_13_1_X_2023-03-19-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8397/31445/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33a70b/31445/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33a70b/31445/git-merge-result

Build

I found compilation error when building:

>> Leaving Package PhysicsTools/ONNXRuntime
>> Package PhysicsTools/ONNXRuntime built
Entering library rule at PhysicsTools/ONNXRuntime
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-19-2300/src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-19-2300/src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc: In constructor 'cms::Ort::ONNXRuntime::ONNXRuntime(const string&, const Ort::SessionOptions*)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-19-2300/src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc:42:40: error: 'struct Ort::Session' has no member named 'GetInputName'
   42 |       std::string input_name(session_->GetInputName(i, allocator));
      |                                        ^~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-19-2300/src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc:51:32: warning: 'void Ort::detail::TensorTypeAndShapeInfoImpl::GetDimensions(int64_t*, size_t) const [with T = Ort::detail::Unowned; int64_t = long int; size_t = long unsigned int]' is deprecated: use GetShape() [-Wdeprecated-declarations]
   51 |       tensor_info.GetDimensions(input_node_dims_[input_name].data(), num_dims);
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


@iarspider
Copy link
Contributor Author

please test with cms-sw/cmssw#41118

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33a70b/31477/summary.html
COMMIT: 8f5b9b5
CMSSW: CMSSW_13_1_X_2023-03-21-0700/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8397/31477/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33a70b/31477/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33a70b/31477/git-merge-result

Build

I found compilation error when building:

>> Leaving Package PhysicsTools/ONNXRuntime
>> Package PhysicsTools/ONNXRuntime built
Entering library rule at PhysicsTools/ONNXRuntime
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-21-0700/src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-21-0700/src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc: In constructor 'cms::Ort::ONNXRuntime::ONNXRuntime(const string&, const Ort::SessionOptions*)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-21-0700/src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc:42:75: error: no matching function for call to 'std::__cxx11::basic_string::basic_string(Ort::AllocatedStringPtr)'
   42 |       std::string input_name(session_->GetInputNameAllocated(i, allocator));
      |                                                                           ^
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/include/c++/11.2.1/string:55,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-21-0700/src/PhysicsTools/ONNXRuntime/interface/ONNXRuntime.h:16,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-21-0700/src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc:8:


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Entering Package RecoParticleFlow/PFProducer
>> Entering Package RecoParticleFlow/PFSimProducer
>> Entering Package SimTracker/TrackTriggerAssociation
>> Entering Package Validation/SiOuterTrackerV
>> Compile sequence completed for CMSSW CMSSW_13_1_X_2023-03-21-0700
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-21-0700/tmp/el8_amd64_gcc11/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package DQMOffline/Trigger
Entering library rule at src/DQMOffline/Trigger/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-21-0700/src/DQMOffline/Trigger/plugins/BPHMonitor.cc


@iarspider
Copy link
Contributor Author

please test with cms-sw/cmssw#41118

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33a70b/31480/summary.html
COMMIT: 8f5b9b5
CMSSW: CMSSW_13_1_X_2023-03-21-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8397/31480/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33a70b/31480/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33a70b/31480/git-merge-result

Build

I found compilation error when building:

Entering library rule at src/DQM/EcalMonitorClient/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-21-1100/src/DQM/EcalMonitorClient/plugins/EcalDQMonitorClient.cc
>> Building edm plugin tmp/el8_amd64_gcc11/src/DQM/EcalMonitorClient/plugins/DQMEcalMonitorClientPlugins/libDQMEcalMonitorClientPlugins.so
Leaving library rule at src/DQM/EcalMonitorClient/plugins
@@@@ Running edmWriteConfigs for DQMEcalMonitorClientPlugins
error: edmWriteConfigs caught an exception while loading a plugin library.
The executable will return success (0) so scram will continue,
but no cfi files will be written.
An exception of category 'PluginLibraryLoadError' occurred.
Exception Message:
unable to load /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-21-1100/tmp/el8_amd64_gcc11/src/DQM/EcalMonitorClient/plugins/DQMEcalMonitorClientPlugins/libDQMEcalMonitorClientPlugins.so because libonnxruntime.so.1.10.0: cannot open shared object file: No such file or directory


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Entering Package RecoParticleFlow/PFProducer
>> Entering Package RecoParticleFlow/PFSimProducer
>> Entering Package SimTracker/TrackTriggerAssociation
>> Entering Package Validation/SiOuterTrackerV
>> Compile sequence completed for CMSSW CMSSW_13_1_X_2023-03-21-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-21-1100/tmp/el8_amd64_gcc11/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package RecoTauTag/HLTProducers
Entering library rule at RecoTauTag/HLTProducers
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-21-1100/src/RecoTauTag/HLTProducers/src/CaloTowerFromL1TCreatorForTauHLT.cc


@smuzaffar
Copy link
Contributor

smuzaffar commented Mar 21, 2023

test parameters:

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33a70b/31488/summary.html
COMMIT: 8f5b9b5
CMSSW: CMSSW_13_1_X_2023-03-21-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8397/31488/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33a70b/31488/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33a70b/31488/git-merge-result

Build

I found compilation error when building:

Entering library rule at src/DQM/EcalMonitorClient/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-21-1100/src/DQM/EcalMonitorClient/plugins/EcalDQMonitorClient.cc
>> Building edm plugin tmp/el8_amd64_gcc11/src/DQM/EcalMonitorClient/plugins/DQMEcalMonitorClientPlugins/libDQMEcalMonitorClientPlugins.so
Leaving library rule at src/DQM/EcalMonitorClient/plugins
@@@@ Running edmWriteConfigs for DQMEcalMonitorClientPlugins
error: edmWriteConfigs caught an exception while loading a plugin library.
The executable will return success (0) so scram will continue,
but no cfi files will be written.
An exception of category 'PluginLibraryLoadError' occurred.
Exception Message:
unable to load /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-21-1100/tmp/el8_amd64_gcc11/src/DQM/EcalMonitorClient/plugins/DQMEcalMonitorClientPlugins/libDQMEcalMonitorClientPlugins.so because libonnxruntime.so.1.10.0: cannot open shared object file: No such file or directory


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Entering Package RecoParticleFlow/PFProducer
>> Entering Package RecoParticleFlow/PFSimProducer
>> Entering Package SimTracker/TrackTriggerAssociation
>> Entering Package Validation/SiOuterTrackerV
>> Compile sequence completed for CMSSW CMSSW_13_1_X_2023-03-21-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-21-1100/tmp/el8_amd64_gcc11/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package HLTrigger/JetMET
Entering library rule at src/HLTrigger/JetMET/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-21-1100/src/HLTrigger/JetMET/plugins/HLTJetTimingFilter.cc


@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2023

Pull request #8397 was updated.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33a70b/31862/summary.html
COMMIT: 8acc5b8
CMSSW: CMSSW_13_1_X_2023-04-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8397/31862/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33a70b/31862/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33a70b/31862/git-merge-result

Comparison Summary

Summary:

  • You potentially added 24 lines to the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3365163
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3365137
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 202 log files, 155 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33a70b/31888/summary.html
COMMIT: 8acc5b8
CMSSW: CMSSW_13_1_X_2023-04-07-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8397/31888/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33a70b/31888/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33a70b/31888/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 15 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3459609
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3459578
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@rappoccio
Copy link

+1

@rappoccio
Copy link

@smuzaffar once you are happy with this I will merge the accompanying PR (cms-sw/cmssw#41118)

@smuzaffar
Copy link
Contributor

smuzaffar commented Apr 10, 2023

@rappoccio , I am happy with this update. please go ahead and merge both PRs.

@rappoccio
Copy link

please merge

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 97e5c60 into IB/CMSSW_13_1_X/master Apr 10, 2023
11 checks passed
@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_1_X/master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants